Repository navigation
refactor: reduce runtime overhead across core, Bridge and clients - #9
Draft
wu-hongjun wants to merge 5 commits into
Draft
wu-hongjun wants to merge 5 commits into
wu-hongjun wants to merge 5 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ten Astra agents audited ten distinct areas and implemented one measured optimization per area. Finished agents were reused for independent cross-review. See the evidence index and plan 099 for reproduction, raw measurements, review findings and limits.
Host results include 8 MP hue tracked peak allocation 762.8 → 10.8 MiB, native RGB Contain composition 4.258 → 0.130 ms, and 256 MiB firmware validator peak RSS 262.47 → 8.58 MiB. These are separate stage/process measurements, not a whole-print or Pi speed claim. Per-area evidence documents noisy/inconclusive measurements and tradeoffs.
Correctness and review
Exact pixels/JPEG/chunks, model orientation, packet error/drain behavior, original ownership and atomic index publication, fresh network snapshots, hashing failures and existing validation paths are preserved. There are no dependency, version, ABI, sync schema or localization changes.
Independent review found and resolved Python-version-dependent FTP test injection. Primary review found and fixed an iOS retry progress regression before acceptance. Tiled hue refinement avoids the original candidate's large temporary arrays. Independent Rust/App, Bridge, hue and iOS review records are included.
Validation
cargo build --workspace --locked,cargo fmt --all -- --check,cargo clippy --workspace --locked -- -D warnings,cargo test --workspace --locked: passed; 349 tests passed, one optional benchmark ignored.bash scripts/check-ffi-header.sh: passed. Rust uses the existing Homebrew static JPEG library through explicitTURBOJPEG_*variables because the host lacks vendored-build prerequisites.bash scripts/test-macos.sh: 165 passed; existing Combine import warnings only. Shell syntax passed.xcodebuild test, signing disabled: 51 executed, zero failures, one existing unavailable-Keychain skip.Hardware and scope
Software image/render/filesystem checks ran on Apple M3 Max / macOS 27.0.1, with an arm64 macOS 15 deployment target. iOS tests used iPhone 17 / iOS 27.0 Simulator. No physical Pi, Printer, camera or iPhone was accessed, no film was used, and no firmware was installed. Pi timing, full pipeline memory, reconnect/upload hardware behavior and battery savings remain unmeasured for these changes. UI layouts and copy are unchanged.