update golang version to 1.19.5 #2666
Conversation
Signed-off-by: yanggang <gang.yang@daocloud.io>
|
Welcome @yanggangtony! |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
@yanggangtony Hey, kindly to ask if there is something making sense for Volcano in go v1.19.5?
no , just upgrade the go version to match the latest go1.19. Is there a good solve to make go: latest? for no need to update go version again? @Thor-wl |
|
It is recommended to postpone the upgrade of the golang version. At present, the latest version of k8s supported by Volcano is v1.25, and k8s v1.25 also uses go 1.19. If there is no special requirement, we can adapt k8s v1.27 version, Corresponding to upgrade the major version of golang. |
Acctually, I'm on @wangyang0616 's side. |
|
@Thor-wl @wangyang0616 So this pr is keep stale? or wait a 1.19 new version have come then to follow it ? for example 1.19.6 is released ,then follow 1.19.5? like these way? thanks yours suggestion. |
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Signed-off-by: yanggang gang.yang@daocloud.io
go1.19.5 have releaed for a time. Update to follow it..
Also go1.20 is released. maybe we should wait for a several versions after ,and follow it.
go release