[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discard --pod-volume-backup-uploader in unified-repo design doc. #7167

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Discard --pod-volume-backup-uploader in unified-repo design doc. #7167

merged 1 commit into from
Dec 5, 2023

Conversation

yanggangtony
Copy link
Contributor
@yanggangtony yanggangtony commented Nov 30, 2023 •
edited
Loading

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes issues 7155

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

Discard --pod-volume-backup-uploader in unified-repo design doc.
fcf5937 
Signed-off-by: yanggang <gang.yang@daocloud.io>
@yanggangtony
Copy link
Contributor Author

/kind changelog-not-required

@github-actions github-actions bot added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Nov 30, 2023
@codecov Codecov
Copy link
codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5cbfd9f) 61.75% compared to head (fcf5937) 61.75%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7167   +/-   ##
=======================================
  Coverage   61.75%   61.75%           
=======================================
  Files         259      259           
  Lines       27894    27894           
=======================================
  Hits        17227    17227           
  Misses       9459     9459           
  Partials     1208     1208

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sseago sseago closed this Nov 30, 2023
@sseago sseago reopened this Nov 30, 2023
@reasonerjt reasonerjt merged commit 905de8c into vmware-tanzu:main Dec 5, 2023
16 of 17 checks passed
@yanggangtony yanggangtony deleted the fix-design-for-unified-repo branch December 5, 2023 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaovilai kaovilai kaovilai approved these changes

@reasonerjt reasonerjt reasonerjt approved these changes

@sseago sseago sseago approved these changes

@ywk253100 ywk253100 Awaiting requested review from ywk253100

Assignees

@yanggangtony yanggangtony

Labels
kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement or discard from design "--pod-volume-backup-uploader" install flag.
4 participants
@yanggangtony @sseago @reasonerjt @kaovilai