[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep the logs info ns/name is the same with other modules. #6779

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Keep the logs info ns/name is the same with other modules. #6779

merged 1 commit into from
Sep 12, 2023

Conversation

yanggangtony
Copy link
Contributor

Thank you for contributing to Velero!

Please add a summary of your change

1 Keep the logs info ns/name is the same with other modules.
2 Delete the const bslLabelKey , let the global const available.
3 Delete unused code of internal/util/managercontroller/managercontroller.go

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

Keep the logs info ns/name is the same with other modules.
76b6077 
Signed-off-by: yanggang <gang.yang@daocloud.io>
@yanggangtony
Copy link
Contributor Author

/kind changelog-not-required

@github-actions github-actions bot added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Sep 6, 2023
@codecov
Copy link
codecov bot commented Sep 6, 2023

Codecov Report

Merging #6779 (76b6077) into main (f72afc8) will decrease coverage by 0.04%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #6779      +/-   ##
==========================================
- Coverage   60.44%   60.41%   -0.04%     
==========================================
  Files         242      242              
  Lines       26023    26023              
==========================================
- Hits        15729    15721       -8     
- Misses       9190     9197       +7     
- Partials     1104     1105       +1
Files Changed Coverage Δ
internal/resourcemodifiers/resource_modifiers.go 75.65% <0.00%> (ø)
internal/resourcepolicies/resource_policies.go 76.54% <0.00%> (ø)
pkg/cmd/cli/backuplocation/delete.go 66.08% <100.00%> (ø)

... and 1 file with indirect coverage changes

@qiuming-best qiuming-best self-assigned this Sep 12, 2023
@qiuming-best qiuming-best merged commit c9fde84 into vmware-tanzu:main Sep 12, 2023
24 of 27 checks passed
@yanggangtony yanggangtony deleted the fix-log-ns-name branch September 12, 2023 10:41
@qiuming-best qiuming-best mentioned this pull request Oct 8, 2023
Merged
3 tasks
@qiuming-best
Copy link
Contributor

it's already cherry-picked to v1.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaovilai kaovilai kaovilai approved these changes

@qiuming-best qiuming-best qiuming-best approved these changes

@sseago sseago sseago approved these changes

Assignees

@qiuming-best qiuming-best

@yanggangtony yanggangtony

Labels
kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes target/1.12.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yanggangtony @qiuming-best @sseago @kaovilai