Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tileset2D.finalize()previously cleared cached tiles without notifying unload handlers. It now emits unload notifications once for each cached entry, aborts pending requests, and reports late results throughonTileDiscard.Rename the public
SharedTile2DHeaderclass toTile2DHeaderin both tiles entry points. Update the deck-layers consumers and API documentation. Consumers should update imports to the new name.Validation: the Chromium tileset lifecycle suite passed all 11 tests, including the new finalize and discard regression.
Note
Low Risk
Low risk lifecycle fix and symbol rename with updated unit tests and documentation.
Overview
Renames
SharedTile2DHeadertoTile2DHeaderacross the@loaders.gl/tilespublic exports, deck-layer consumers, and API documentation.Updates
Tileset2D.finalize()to notify listeners and callers via_handleTileUnloadfor each cached tile during teardown, ensuring unload callbacks fire consistently when finalizing.Reviewed by Cursor Bugbot for commit 9df9628. Bugbot is set up for automated code reviews on this repo. Configure here.