8000 Persist auto-size mode per bin by jasonmadigan · Pull Request #252 · tracefinity/tracefinity · GitHub
[go: up one dir, main page]

Skip to content

Persist auto-size mode per bin - #252

Merged
jasonmadigan merged 2 commits into
mainfrom
fix/250-auto-size-persistence
Nov 14, 2026
Merged

jasonmadigan merged 2 commits into
mainfrom
fix/250-auto-size-persistence

Conversation

@jasonmadigan
@jasonmadigan jasonmadigan commented Nov 14, 2026 •
Copy link
Copy Markdown
Collaborator

Summary

Reopening a bin enabled auto-size again and could replace a saved 2×1 grid with 3×1. Save the choice per bin and restore it before fitting tools.

 reopen bin
- enable auto-size
+ restore saved auto-size
  fit grid when enabled

Pin the E2E job to Ubuntu 24.04, which the installed Playwright version supports.

Closes #250.

Evidence

  • Before: reopening reset the toggle and overwrote a saved manual width.
    After: off/on survives reload and navigation; manual dimensions and tool positions are preserved.
  • make lint: passed, nine ESLint warnings in unchanged files.
  • Backend: venv/bin/python -m pytest -q, 873 passed.
  • Frontend: pnpm test, 299 passed.
  • make test-e2e-accuracy: 7 passed, including both persistence regressions.

Merge Danger

Door: two-way. Existing bins default to auto-size on.

Blast Radius: bins. Adds a saved editor preference outside the geometry configuration.

Signed-off-by: Jason Madigan <jason@jasonmadigan.com>
Signed-off-by: Jason Madigan <jason@jasonmadigan.com>
@jasonmadigan
jasonmadigan marked this pull request as ready for review November 14, 2026 19:00
@jasonmadigan
jasonmadigan merged commit b8875e7 into main Nov 14, 2026
6 checks passed
@jasonmadigan
jasonmadigan deleted the fix/250-auto-size-persistence branch November 14, 2026 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auto-Size Grid State not Remembered/Saved Per Bin

1 participant

0