8000 Fix stacking lip cutout depth limits by jasonmadigan · Pull Request #217 · tracefinity/tracefinity · GitHub
[go: up one dir, main page]

Skip to content

Fix stacking lip cutout depth limits - #217

Merged
jasonmadigan merged 1 commit into
mainfrom
fix/216-cutout-depth
Sep 9, 2026
Merged

jasonmadigan merged 1 commit into
mainfrom
fix/216-cutout-depth

Conversation

@jasonmadigan
Copy link
Copy Markdown
Collaborator

Summary

  • Allow 7 mm pockets in 2u bins and 14 mm pockets in 3u bins with the stacking lip enabled. Remove the extra lip deduction from UI and generator limits while preserving the base and 2 mm floor.
  • Give the physical maximum precedence over the 5 mm minimum: 1u bins now show and save a 0.25 mm pocket limit, with guidance to increase height. Per-feature controls follow the same bounds.
  • Version generation cache keys so existing previews and exports regenerate on their next generation request. Correct the height guidance and total-height display, which previously counted the base twice.

Test evidence

  • make lint — passed, including TypeScript checks; 9 lint warnings.
  • cd backend && venv/bin/python -m pytest — 782 passed.
  • cd frontend && pnpm test — 223 passed.
  • Exported-mesh regressions measure pocket depth and retained floor thickness with the lip on/off, raised rims, tool/finger-hole overrides, and insert allowances. Cache tests verify old exports regenerate and subsequent requests reuse the new cache.
  • Chrome check of the configurator: 2u accepts 7 mm, 3u accepts 14 mm, and reducing height to 1u displays 0.25 mm and the shallow-pocket guidance.

Same 2u configuration and requested 7 mm pocket, rendered with the previous and corrected configurators:

Cutout depth before and after

Closes #216

Signed-off-by: Jason Madigan <jason@jasonmadigan.com>
@jasonmadigan jasonmadigan self-assigned this Sep 9, 2026
@jasonmadigan
jasonmadigan marked this pull request as ready for review September 9, 2026 11:21
@jasonmadigan
jasonmadigan merged commit 848c2b3 into main Sep 9, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix stacking lip unnecessarily limiting cutout depth

1 participant

0