8000 Replace the grid clamp with resource-aware limits by jasonmadigan · Pull Request #190 · tracefinity/tracefinity · GitHub
[go: up one dir, main page]

Skip to content

Replace the grid clamp with resource-aware limits - #190

Merged
jasonmadigan merged 1 commit into
mainfrom
fix/186-grid-size-limits
Aug 21, 2026
Merged

jasonmadigan merged 1 commit into
mainfrom
fix/186-grid-size-limits

Conversation

@jasonmadigan
Copy link
Copy Markdown
Collaborator

Summary

  • Replace the arbitrary 10-unit-per-axis clamp with a 25-unit sanity ceiling and a 100-cell resource limit, allowing long split bins without increasing the existing worst-case geometry footprint.
  • Keep oversized layouts saved while pausing preview and export with an explicit warning, instead of silently clipping tool cutouts.
  • Apply the same rules across API-created bins, editor controls, validation diagnostics, and user documentation.

Test evidence

  • backend/venv/bin/pytest backend/tests -q — 325 passed.
  • make lint — passed (ruff, ESLint with 9 pre-existing warnings, and tsc --noEmit).
  • pnpm exec vitest run src/lib/gridSize.test.ts src/components/BinConfigurator.test.ts --reporter=verbose — 13 passed.
  • Full frontend Vitest reached 117 passing tests, but exited non-zero because five jsdom workers could not start: installed undici@8.10.0 lacks undici/lib/handler/wrap-handler.js. This dependency/runtime issue is present independently of this patch.

Closes #186

Signed-off-by: Jason Madigan <jason@jasonmadigan.com>
@jasonmadigan
jasonmadigan marked this pull request as ready for review August 21, 2026 12:00
@jasonmadigan
jasonmadigan merged commit d7f8b1b into main Aug 21, 2026
4 checks passed
@jasonmadigan
jasonmadigan deleted the fix/186-grid-size-limits branch August 21, 2026 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PUT /api/bins/{id} returns 422 and the bin editor silently discards the edit

1 participant

0