Repository navigation
ci: fail on next-env.d.ts drift via next typegen - #183
Merged
Merged
Conversation
frontend build regenerates next-env.d.ts in the runner, so a stale committed copy never surfaced in CI. run next typegen (no full build) and git diff --exit-code to catch drift on PRs. Signed-off-by: Jason Madigan <jason@jasonmadigan.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The frontend build regenerates next-env.d.ts inside the runner, so a stale committed copy never surfaced in CI (as happened after the next 16.3.1 bump in #182).
Adds two steps to the frontend lint job: run
next typegen(generates route types without a full build) thengit diff --exit-code -- frontend/next-env.d.ts. Fails the PR if the committed generated file drifts.Validated locally: typegen on clean main reproduces the committed file exactly (gate passes); on the pre-fix drift it fails.