8000 fix: stop discarding failed bin saves silently, log 422 detail by jasonmadigan · Pull Request #188 · tracefinity/tracefinity · GitHub
[go: up one dir, main page]

Skip to content

fix: stop discarding failed bin saves silently, log 422 detail - #188

Merged
jasonmadigan merged 2 commits into
mainfrom
fix/bin-save-failures
Aug 19, 2026
Merged

jasonmadigan merged 2 commits into
mainfrom
fix/bin-save-failures

Conversation

@jasonmadigan
@jasonmadigan jasonmadigan commented Aug 19, 2026 •
Copy link
Copy Markdown
Collaborator

Re #186.

Adds additional logging: a 422 now records the failing field and error type rather than just a status code. Never the value.

Also stops the bin editor discarding failed saves. The page dropped the promise and the hook swallowed the rejection, so a failed autosave showed the same green tick as a success.

Does not identify the 422 trigger.

A failing autosave was invisible from both ends.

Client: the bin page dropped the promise with .catch(() => {}) before
useDebouncedSave could see it, and the hook swallowed anything that did
reach it with an empty catch. A rejected save left the editor showing the
same green tick as a successful one, so work looked saved when it was not.
The hook now exposes the error, the bin page awaits the request instead of
dropping it, and a failure is shown next to the breadcrumb with a warning
that unsaved edits will be lost on leaving.

Server: a 422 recorded nothing but a status code in the access log, so a
client sending a bad payload could not be diagnosed after the fact. Log the
field path and error type on validation failure, never the value, since
payloads carry user data.

The other two useDebouncedSave callers already awaited correctly and are
unaffected.

Re: #186
Signed-off-by: Jason Madigan <jason@jasonmadigan.com>
The install step re-downloaded chromium every run and shelled out to apt via
--with-deps, which stalled for 13 minutes and consumed the whole 15 minute job
budget before any test ran. The job reported as cancelled, which reads like a
test failure rather than an install hang.

Cache the browsers, skip apt on a cache hit, and bound the step at 5 minutes so
a stall fails honestly. Also cache pip: the backend install pulls torch and the
full CUDA wheel set on every run.

Signed-off-by: Jason Madigan <jason@jasonmadigan.com>
@jasonmadigan
jasonmadigan merged commit 44f645b into main Aug 19, 2026
4 checks passed
@jasonmadigan
jasonmadigan deleted the fix/bin-save-failures branch August 19, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0