8000 Require proxy secret for user namespaces by jasonmadigan · Pull Request #179 · tracefinity/tracefinity · GitHub
[go: up one dir, main page]

Skip to content

Require proxy secret for user namespaces - #179

Merged
jasonmadigan merged 1 commit into
mainfrom
fix/177-trusted-user-header
Aug 11, 2026
Merged

jasonmadigan merged 1 commit into
mainfrom
fix/177-trusted-user-header

Conversation

@jasonmadigan
Copy link
Copy Markdown
Collaborator

Important

Standard standalone and configured trusted-proxy deployments are unchanged. Custom proxies that send X-User-Id without configuring PROXY_SECRET will now receive 403.

Summary

  • reject user namespace selection on API and storage paths unless a trusted proxy secret is configured
  • preserve header-free standalone requests, health checks, and authenticated multi-user proxy behavior
  • document the namespace contract and exercise existing multi-user tests through it

Test evidence

  • backend/venv/bin/pytest -q backend/tests/test_proxy_middleware.py backend/tests/test_user_deletion.py — 13 passed
  • backend/venv/bin/pytest -q backend/tests — 310 passed
  • make lint — passed; frontend ESLint reported 9 existing warnings and no errors

Closes #177

@jasonmadigan
jasonmadigan marked this pull request as ready for review August 11, 2026 10:48
@jasonmadigan
jasonmadigan merged commit 346e427 into main Aug 11, 2026
4 checks passed
@jasonmadigan
jasonmadigan deleted the fix/177-trusted-user-header branch August 11, 2026 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Arbitrary X-User-Id header creates storage directories (unbounded disk usage)

1 participant

0