Repository navigation
Add dashboard tool status filters - #162
Merged
Merged
Conversation
noobydp
marked this pull request as ready for review
August 3, 2026 04:37
Collaborator
|
👀 |
jasonmadigan
approved these changes
Aug 17, 2026
Collaborator
There was a problem hiding this comment.
two small nits, but not blockers or anything:
getToolQuickFilterCountsruns two fulltools.filter()passes (placed + unassigned). For the list sizes on this dashboard it's a non-issue, but a single pass accumulating both counters would be marginally cleaner.- The Tools section header count changed from
toolsList.lengthtofilteredTools.length. I think showing the post-filter count next to the section title is fine, and the per-button counts make it self-explanatory just flagging it since it's a visible behavior change beyond the PR summary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Behavior
Placed includes tools assigned to a project and present in one of that project's bins. Unassigned includes tools that belong to no project. Assigned tools that still need a bin remain available under All.
The filter-button movement was caused by inactive buttons using
glass-sm, which adds a 1px border, while the active state removed that class. Keepingglass-smin both states preserves the button geometry while allowing the active background and text colors to change.Validation
pnpm exec vitest run— 15 test files and 118 tests passedpnpm exec eslint src/app/page.tsx src/app/projects/[id]/page.tsx— no errors; two existing warningspnpm exec tsc --noEmitpnpm exec next buildCode and PR drafted with Codex