8000 Add dashboard tool status filters by noobydp · Pull Request #162 · tracefinity/tracefinity · GitHub
[go: up one dir, main page]

Skip to content

Add dashboard tool status filters - #162

Merged
jasonmadigan merged 1 commit into
tracefinity:mainfrom
noobydp:codex/tool-quick-filters
Aug 17, 2026
Merged

jasonmadigan merged 1 commit into
tracefinity:mainfrom
noobydp:codex/tool-quick-filters

Conversation

@noobydp
@noobydp noobydp commented Aug 3, 2026
Copy link
Copy Markdown
Contributor

Summary

  • add All, Placed, and Unassigned quick filters to the dashboard Tools section, with live counts and accessible pressed states
  • compose the status filters with the existing search and sort controls, including a clear empty-results state
  • centralize tool-status classification in tested selector helpers
  • keep the glass border present in active and inactive filter states so the dashboard and project tool filters no longer shift when clicked

Behavior

Placed includes tools assigned to a project and present in one of that project's bins. Unassigned includes tools that belong to no project. Assigned tools that still need a bin remain available under All.

The filter-button movement was caused by inactive buttons using glass-sm, which adds a 1px border, while the active state removed that class. Keeping glass-sm in both states preserves the button geometry while allowing the active background and text colors to change.

Validation

  • pnpm exec vitest run — 15 test files and 118 tests passed
  • pnpm exec eslint src/app/page.tsx src/app/projects/[id]/page.tsx — no errors; two existing warnings
  • pnpm exec tsc --noEmit
  • pnpm exec next build

Code and PR drafted with Codex

@noobydp
noobydp marked this pull request as ready for review August 3, 2026 04:37
@jasonmadigan
Copy link
Copy Markdown
Collaborator

👀

@jasonmadigan jasonmadigan left a comment •
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two small nits, but not blockers or anything:

  1. getToolQuickFilterCounts runs two full tools.filter() passes (placed + unassigned). For the list sizes on this dashboard it's a non-issue, but a single pass accumulating both counters would be marginally cleaner.
  2. The Tools section header count changed from toolsList.length to filteredTools.length. I think showing the post-filter count next to the section title is fine, and the per-button counts make it self-explanatory just flagging it since it's a visible behavior change beyond the PR summary.

@jasonmadigan
jasonmadigan merged commit 0ccaad1 into tracefinity:main Aug 17, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0