Repository navigation
Delete dead drawer_store.py - #158
Merged
Merged
Conversation
DrawerStore was imported nowhere and importing it r 8000 aised ImportError because DrawerModel does not exist in app/models/schemas.py. Remove the file and the stale excluded-store comment in the load-error tests. Closes #157 Signed-off-by: Jason Madigan <jason@jasonmadigan.com>
drawer_store.py was its only producer and never ran (ImportError), so the file never existed in storage. Per review feedback. Signed-off-by: Jason Madigan <jason@jasonmadigan.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
backend/app/services/drawer_store.py: imported nowhere, and importing it raisesImportErrorbecauseDrawerModeldoes not exist inapp/models/schemas.py. Noticed while investigating Investigate running the backend as multiple processes or replicas #155.backend/tests/test_store_load_errors.py.Test evidence
make lint: pass (0 errors; 9 pre-existing frontend warnings, untouched)pytest tests/: 290 passedCloses #157