8000 Drawer plans for projects by gr3enk · Pull Request #148 · tracefinity/tracefinity · GitHub
[go: up one dir, main page]

Skip to content

Drawer plans for projects - #148

Merged
jasonmadigan merged 6 commits into
tracefinity:mainfrom
gr3enk:140-project-planning
Sep 21, 2026
Merged

jasonmadigan merged 6 commits into
tracefinity:mainfrom
gr3enk:140-project-planning

Conversation

@gr3enk
@gr3enk gr3enk commented Jul 26, 2026
Copy link
Copy Markdown
Contributor

Changes

This PR adds the ability to plan the layout of project bins. The route project/[id]/sketch/[sketchId] has been created for this purpose. On this page, the project’s bins can be arranged on a defined grid (in Gridfinity units). In addition, the bins can be colour-coded for easier organisation. However, it is not yet possible to stack multiple bins on top of one another.

closes #140

Screenshots

CleanShot 2026-07-27 at 00 02 36@2x CleanShot 2026-07-27 at 00 03 02@2x CleanShot 2026-07-27 at 00 03 22@2x

@gr3enk
gr3enk commented Jul 26, 2026
Copy link
Copy Markdown
Contributor Author

What do you think of this approach @jasonmadigan? This PR has grown quite large by now, which is why I wanted to get some feedback first, before I get too sidetracked. I’d already thought about a feature like this before, but I wasn’t sure about the best way to implement it.

@jem24h
jem24h commented Aug 5, 2026
Copy link
Copy Markdown

This looks very promising, can't wait !

@jasonmadigan jasonmadigan left a comment
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gr3enk — the feature direction and overall approach fit the project well. A few workflow issues remain; happy to re-review and look to merge once these are addressed.

gr3enk and others added 3 commits September 18, 2026 12:17
Resolve import conflicts in backend/app/api/routes.py and
backend/app/models/schemas.py: both sides only added imports
(sketch schemas and re/uuid here, photo-station schemas and math
upstream), so all of them are kept.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@gr3enk
gr3enk commented Sep 18, 2026
Copy link
Copy Markdown
Contributor Author

Review follow-up

  • Failed saves are no longer reported as saved. The drawer plan now
    lets save errors reach useDebouncedSave and shows the same "Changes are
    not being saved" state as the bin page.
  • 3D models no longer get stuck as placeholders. STL loading moved into
    a new useBinStlUrls hook. Previously, leaving the 3D view or dragging,
    rotating or recolouring a bin while models were generating cancelled the
    run without releasing its requests. Each request now either yields a model
    or is released for the next run.
  • Auto arrange never removes placements. Placements that do not fit keep
    their previous position and are marked with the dashed conflict outline;
    a notice tells the user what did not fit. On an empty plan, bins that do
    not fit are simply not added.

@jasonmadigan

@gr3enk
gr3enk marked this pull request as ready for review September 18, 2026 11:01
@gr3enk
gr3enk requested a review from jasonmadigan September 18, 2026 11:02
@jem24h
jem24h commented Sep 18, 2026
Copy link
Copy Markdown

Thank you for your work, can't wait to try this feature !

@jasonmadigan jasonmadigan left a comment •
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working through the round one feedback. The save-error surfacing and the STL request cleanup both hold up under testing, and preserving non-fitting placements is what was wanted.

Five inline comments below, mostly data-loss paths, all reproducible from a clean install.

Three that do not map to a line: the drawer canvas has no keyboard path to select or move a bin, "Clear drawer size" also wipes every placement with no undo, and the PR body needs a test plan per CONTRIBUTING.

Happy to re-review and look to merge once these are sorted. I look forward to merging this one!

Comment thread backend/app/api/routes.py
name = req.name.strip()
if not name:
raise HTTPException(status_code=400, detail="sketch name is required")
sketch.name = name
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

project_store.get() returns the live project, so these assignments land before validate_bin_layout on line 1913 can raise. An invalid layout returns 400 but the rename and grid stay in memory, and the next write to any project flushes the whole store to disk, so it persists under an unrelated operation with updated_at unchanged. Could we validate into a local first and assign only once it passes?

Comment thread backend/app/models/schemas.py Resolved
Comment thread frontend/src/lib/drawerLayout.ts Resolved
@gr3enk
gr3enk requested a review from jasonmadigan September 20, 2026 11:39
@jasonmadigan jasonmadigan left a comment
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good enough to merge thanks @gr3enk!

I do plan to make some small UX tweaks here and there for consistency's sake (and because I promised myself I'd remain the arbiter of UX rather than AI or others for this project generally!)

@jasonmadigan
jasonmadigan merged commit 13a00d3 into tracefinity:main Sep 21, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request : Project/drawer space usage

3 participants

0