Repository navigation
Drawer plans for projects - #148
Conversation
|
What do you think of this approach @jasonmadigan? This PR has grown quite large by now, which is why I wanted to get some feedback first, before I get too sidetracked. I’d already thought about a feature like this before, but I wasn’t sure about the best way to implement it. |
|
This looks very promising, can't wait ! |
There was a problem hiding this comment.
Thanks @gr3enk — the feature direction and overall approach fit the project well. A few workflow issues remain; happy to re-review and look to merge once these are addressed.
Resolve import conflicts in backend/app/api/routes.py and backend/app/models/schemas.py: both sides only added imports (sketch schemas and re/uuid here, photo-station schemas and math upstream), so all of them are kept. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Review follow-up
|
|
Thank you for your work, can't wait to try this feature ! |
There was a problem hiding this comment.
Thanks for working through the round one feedback. The save-error surfacing and the STL request cleanup both hold up under testing, and preserving non-fitting placements is what was wanted.
Five inline comments below, mostly data-loss paths, all reproducible from a clean install.
Three that do not map to a line: the drawer canvas has no keyboard path to select or move a bin, "Clear drawer size" also wipes every placement with no undo, and the PR body needs a test plan per CONTRIBUTING.
Happy to re-review and look to merge once these are sorted. I look forward to merging this one!
| name = req.name.strip() | ||
| if not name: | ||
| raise HTTPException(status_code=400, detail="sketch name is required") | ||
| sketch.name = name |
There was a problem hiding this comment.
project_store.get() returns the live project, so these assignments land before validate_bin_layout on line 1913 can raise. An invalid layout returns 400 but the rename and grid stay in memory, and the next write to any project flushes the whole store to disk, so it persists under an unrelated operation with updated_at unchanged. Could we validate into a local first and assign only once it passes?
There was a problem hiding this comment.
this looks good enough to merge thanks @gr3enk!
I do plan to make some small UX tweaks here and there for consistency's sake (and because I promised myself I'd remain the arbiter of UX rather than AI or others for this project generally!)
Changes
This PR adds the ability to plan the layout of project bins. The route
project/[id]/sketch/[sketchId]has been created for this purpose. On this page, the project’s bins can be arranged on a defined grid (in Gridfinity units). In addition, the bins can be colour-coded for easier organisation. However, it is not yet possible to stack multiple bins on top of one another.closes #140
Screenshots