[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dune: js_of_ocaml.weak and js_of_ocaml.ppx don't seem to exist anymore? #321

Closed
wants to merge 1 commit into from

Conversation

maelvls
Copy link
Member
@maelvls maelvls commented Jul 18, 2024

I've used the Dune sample that is visible in https://dune.readthedocs.io/en/stable/jsoo.html:

(executable
   (name foo)
   (modes js)
   (preprocess (pps js_of_ocaml-ppx)))

But it seems like there are still problems while compiling:

$ dune build
Entering directory '/Users/mvalais/code/touist'
File "src/lib/satSolve.ml", line 24, characters 11-35:
24 |         if Minisat.Raw.add_clause_a solver a then add_clauses solver next
                ^^^^^^^^^^^^^^^^^^^^^^^^
Error: Unbound module Minisat.Raw

Reproducing this error

First, I followed the instructions in https://github.com/touist/touist/blob/master/INSTALL.md :

brew install ocaml opamopam init -y --shell-setup
opam install . --deps-only --with-test

Voici les versions d'OCaml que j'ai utilisées :

$ opam switch
#  switch   compiler                                            description
$ ocaml --version
The OCaml toplevel, version 4.14.0

I then followed the instructions in https://github.com/touist/touist/blob/master/src/js/dune:

opam install js_of_ocaml js_of_ocaml-ppx js_of_ocaml-compiler yojson ppx_deriving_yojson

Then, I tried building touistjs.bc.js:

cd src/js/
dune build

and got the error:

Error: Unbound module Minisat.Raw

I seems like Minisat.Raw was removed in June 2023: c-cube/ocaml-minisat@d85a450. Not sure why... That will need fixing to make everything work again.

I've used the Dune sample that is visible in https://dune.readthedocs.io/en/stable/jsoo.html:

  (executable
   (name foo)
   (modes js)
   (preprocess (pps js_of_ocaml-ppx)))
@maelvls
Copy link
Member Author
maelvls commented Jul 18, 2024

I opened this PR as an example in order to unblock Cédric JEANJEAN. Closing since I won't be able to fix this further. Please feel free to steal the changes in my PR in order to create your own 👍

@maelvls maelvls closed this Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant