[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix grammar #749

Merged
merged 3 commits into from
Nov 6, 2023
Merged

docs: fix grammar #749

merged 3 commits into from
Nov 6, 2023

Conversation

EricCrosson
Copy link
Contributor
@EricCrosson EricCrosson commented Oct 29, 2023

Hello,

I've been going through the introductory docs today and found a minor typo. Thanks for your work writing and maintaining these docs -- they're a great introduction!

Cheers

This commit uses the correct form of "it's".

"Its" is possessive describes a noun, while "it's" is a contraction that
is short for "it is". Since "ready" is not a noun, we must use the
contraction in this case.
@EricCrosson EricCrosson marked this pull request as ready for review October 29, 2023 17:11
Copy link
Contributor
@GlenDC GlenDC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member
@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix! while we're changing this, we should probably add some missing commas.

guides/building-a-middleware-from-scratch.md Outdated Show resolved Hide resolved
guides/building-a-middleware-from-scratch.md Outdated Show resolved Hide resolved
guides/building-a-middleware-from-scratch.md Outdated Show resolved Hide resolved
@hawkw hawkw enabled auto-merge (squash) November 6, 2023 21:26
@hawkw hawkw merged commit 39adf5c into tower-rs:master Nov 6, 2023
14 checks passed
@EricCrosson EricCrosson deleted the docs-fix-grammar branch November 7, 2023 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants