[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RMB on VideoThumbnail opens default context menu on Web (#196) #198

Merged
merged 6 commits into from
Nov 4, 2022

Conversation

krida2000
Copy link
Contributor
@krida2000 krida2000 commented Nov 3, 2022

Resolves #196

Synopsis

При нажатии ПКМ по превьюшкам видео в сообщениях открывается контекстное меню браузера, хотя правильнее его игнорировать.

Solution

Проблема будет исправлена.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@krida2000 krida2000 self-assigned this Nov 3, 2022
@krida2000 krida2000 added enhancement Improvement of existing features or bugfix k::UI/UX UI (user interface) and UX (user experience) changes labels Nov 3, 2022
@krida2000 krida2000 added this to the 0.1.0-alpha.8 milestone Nov 3, 2022
@krida2000
Copy link
Contributor Author
krida2000 commented Nov 3, 2022

FCM

Fix default context menu displaying over `VideoThumbnail`s on Web (#198, #196)

@krida2000 krida2000 marked this pull request as ready for review November 3, 2022 09:23
@SleepySquash SleepySquash enabled auto-merge (squash) November 4, 2022 09:25
@SleepySquash SleepySquash merged commit a7cbaa7 into main Nov 4, 2022
@SleepySquash SleepySquash deleted the 196-fix-default-context-menu-opening-on-video branch November 4, 2022 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing features or bugfix k::UI/UX UI (user interface) and UX (user experience) changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RMB on VideoThumbnail opens default context menu on Web
2 participants