[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chat muting/unmuting (#63) #172

Merged
merged 40 commits into from
Nov 15, 2022
Merged

Chat muting/unmuting (#63) #172

merged 40 commits into from
Nov 15, 2022

Conversation

skazkiful
Copy link
Contributor
@skazkiful skazkiful commented Oct 12, 2022 •
edited by SleepySquash
Loading

Resolves #63

Synopsis

Backend allows Chats to be muted for a certain amount of time (or forever) and unmuted.

Solution

Implement:

  1. Ability to mute chat for a duration or forever.
  2. Ability to unmute chats.
  3. Mute implementation (no sound/local notifications should be played).
  4. Chat being muted indicator.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@skazkiful skazkiful changed the title Chat muting/unmuting Chat muting/unmuting (#63) Oct 12, 2022
@skazkiful skazkiful self-assigned this Oct 12, 2022
@skazkiful skazkiful added feature New feature or request k::UI/UX UI (user interface) and UX (user experience) changes k::design Changes of application architecture and implementation design labels Oct 12, 2022
@skazkiful skazkiful added this to the 0.1.0-alpha.7 milestone Oct 12, 2022
@skazkiful
Merge remote-tracking branch 'origin/main' into 63-chat-muting-and-un…
529c5df 
…muting

# Conflicts:
#	lib/domain/repository/chat.dart
#	lib/domain/service/chat.dart
#	lib/provider/gql/exceptions.dart
#	lib/store/chat.dart
@skazkiful
some changes
6cda259
@skazkiful
Some changes
65efb02
@skazkiful
Fix CI
255bb90
@skazkiful
Change parser
11dfd7d
@skazkiful
Some changes
2d37d8b
@skazkiful
Some changes
0b1ffd9
@skazkiful
Copy link
Contributor Author
skazkiful commented Oct 19, 2022 •
edited by SleepySquash
Loading

FCM

Implement `Chat` muting/unmuting (#172, #63)

Additionally:
- fix incorrect `PreciseDateTime` parsing and persisting
- fix `ConfirmDialog` not being scrollable

@skazkiful skazkiful marked this pull request as ready for review October 19, 2022 15:27
@SleepySquash SleepySquash requested review from krida2000 and removed request for SleepySquash October 19, 2022 15:42
SleepySquash
SleepySquash requested changes Oct 21, 2022
View reviewed changes
Copy link
Contributor
@SleepySquash SleepySquash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skazkiful

lib/domain/repository/chat.dart Outdated Show resolved Hide resolved
lib/api/backend/graphql/parsers/precise_date_time.dart Show resolved Hide resolved
lib/store/chat_rx.dart Outdated Show resolved Hide resolved
lib/ui/page/home/tab/chats/controller.dart Outdated Show resolved Hide resolved
lib/ui/page/home/tab/chats/controller.dart Outdated Show resolved Hide resolved
test/e2e/features/chat/toggle_chat_mute/.feature Outdated Show resolved Hide resolved
test/e2e/features/chat/toggle_chat_mute/.feature Outdated Show resolved Hide resolved
test/e2e/features/chat/toggle_chat_mute/.feature Outdated Show resolved Hide resolved
test/e2e/features/chat/toggle_chat_mute/.feature Outdated Show resolved Hide resolved
lib/store/chat.dart Outdated Show resolved Hide resolved
@SleepySquash SleepySquash marked this pull request as draft October 21, 2022 08:21
@skazkiful skazkiful marked this pull request as ready for review November 9, 2022 19:14
SleepySquash
SleepySquash requested changes Nov 11, 2022
View reviewed changes
lib/ui/page/home/tab/chats/view.dart Outdated Show resolved Hide resolved
lib/ui/page/home/tab/chats/widget/mute_chat_popup.dart Outdated Show resolved Hide resolved
lib/ui/page/home/tab/chats/widget/mute_chat_popup.dart Outdated Show resolved Hide resolved
lib/ui/page/home/tab/chats/widget/mute_chat_popup.dart Outdated Show resolved Hide resolved
@SleepySquash SleepySquash marked this pull request as draft November 11, 2022 10:29
@skazkiful skazkiful marked this pull request as ready for review November 11, 2022 14:08
SleepySquash
SleepySquash requested changes Nov 14, 2022
View reviewed changes
Copy link
Contributor
@SleepySquash SleepySquash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skazkiful, два момента по дизайну: вопрос по шапке и плямба замьюченности.

lib/ui/page/home/page/chat/view.dart Show resolved Hide resolved
lib/ui/page/home/page/chat/view.dart Outdated Show resolved Hide resolved
lib/ui/page/home/tab/chats/mute_chat_popup/controller.dart Outdated Show resolved Hide resolved
lib/ui/page/home/tab/chats/widget/recent_chat.dart Outdated Show resolved Hide resolved
@SleepySquash SleepySquash marked this pull request as draft November 14, 2022 12:35
@skazkiful skazkiful marked this pull request as ready for review November 14, 2022 17:35
@SleepySquash SleepySquash added k::refactor Refactor changes of existing code and removed k::design Changes of application architecture and implementation design labels Nov 15, 2022
@SleepySquash SleepySquash enabled auto-merge (squash) November 15, 2022 09:36
@SleepySquash SleepySquash merged commit 2814a6f into main Nov 15, 2022
@SleepySquash SleepySquash deleted the 63-chat-muting-and-unmuting branch November 15, 2022 09:52
github-actions bot added a commit that referenced this pull request Nov 15, 2022
@github-actions
Implement Chat muting/unmuting (#172, #63)
465f465 
Additionally:
- fix incorrect `PreciseDateTime` parsing and persisting
- fix `ConfirmDialog` not being scrollable 2814a6f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krida2000 krida2000 krida2000 approved these changes

@SleepySquash SleepySquash SleepySquash approved these changes

Assignees

@skazkiful skazkiful

Labels
feature New feature or request k::refactor Refactor changes of existing code k::UI/UX UI (user interface) and UX (user experience) changes
Projects
None yet
Milestone
0.1.0-alpha.8
Development

Successfully merging this pull request may close these issues.

Chat muting/unmuting
3 participants
@skazkiful @SleepySquash @krida2000