[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign Chats tab (#124) #142

Merged
merged 61 commits into from
Oct 31, 2022
Merged

Redesign Chats tab (#124) #142

merged 61 commits into from
Oct 31, 2022

Conversation

ArturRubets
Copy link
Contributor
@ArturRubets ArturRubets commented Sep 19, 2022 •
edited by SleepySquash
Loading

Part of #124

Synopsis

CustomAppBar, интерфейс навигации, отображение вкладок чатов и вкладок контактов. На вкладке чатов: новое отображение текущего звонка в чате, отображение "печатает".

Solution

Перенести из ветки new-design-preview.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@ArturRubets ArturRubets added enhancement Improvement of existing features or bugfix roadmap Issue/PR summarizes some steps which consist of another issues and PRs k::UI/UX UI (user interface) and UX (user experience) changes k::refactor Refactor changes of existing code labels Sep 19, 2022
@ArturRubets ArturRubets added this to the 0.1.0-alpha.6 milestone Sep 19, 2022
@ArturRubets ArturRubets self-assigned this Sep 19, 2022
@ArturRubets ArturRubets changed the title Part 2 of Home and Chat UI redesign #124 Part 2 of Home and Chat UI redesign #124 Sep 19, 2022
@ArturRubets
Copy link
Contributor Author
ArturRubets commented Sep 23, 2022 •
edited by SleepySquash
Loading

FCM

Redesign `Chat`s tab (#142)

- impl `RecentChatTile`, `ChatTile`, `PeriodicBuilder` and `InkWellWithHover`
- make `RouterState.routes` reactive
- redesign `Home` navigation bar

Additionally:
- add `RxChat.id` convenience getter 
- impl `ChatMemberInfo` notification in `Chat` worker

@ArturRubets ArturRubets marked this pull request as ready for review September 23, 2022 05:49
@ArturRubets ArturRubets changed the title Part 2 of Home and Chat UI redesign #124 Redesign sidebar Sep 23, 2022
SleepySquash
SleepySquash requested changes Sep 23, 2022
View reviewed changes
Copy link
Contributor
@SleepySquash SleepySquash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArturRubets, кое-где тяп-ляп получился. Просьба не забывать внимательно вычитывать задачу перед отправкой на review. Можно даже использовать интерфейс гитхаба - Files changed, там можно тыкать галочки на файлы, которые Вы просмотрели и в которых уверены.

lib/ui/page/home/widget/avatar.dart Outdated Show resolved Hide resolved
lib/ui/page/home/widget/navigation_bar.dart Outdated Show resolved Hide resolved
lib/ui/page/home/widget/gallery.dart Outdated Show resolved Hide resolved
lib/ui/page/home/tab/chats/widget/hovered_ink.dart Outdated Show resolved Hide resolved
lib/ui/page/home/tab/chats/widget/hovered_ink.dart Outdated Show resolved Hide resolved
lib/ui/page/home/tab/chats/view.dart Outdated Show resolved Hide resolved
lib/ui/page/home/tab/chats/view.dart Outdated Show resolved Hide resolved
lib/ui/page/home/tab/chats/view.dart Outdated Show resolved Hide resolved
lib/ui/page/home/tab/chats/view.dart Outdated Show resolved Hide resolved
lib/ui/page/home/page/chat/view.dart Outdated Show resolved Hide resolved
@SleepySquash SleepySquash marked this pull request as draft September 23, 2022 11:24
@krida2000 krida2000 changed the title Redesign sidebar (#142) Redesign sidebar (#124) Oct 14, 2022
@SleepySquash SleepySquash requested review from skazkiful and removed request for SleepySquash October 18, 2022 07:28
@krida2000 krida2000 marked this pull request as ready for review October 21, 2022 07:42
@SleepySquash SleepySquash changed the title Redesign sidebar (#124) Redesign Chats tab (#124) Oct 31, 2022
@SleepySquash SleepySquash merged commit 8e1190b into main Oct 31, 2022
@SleepySquash SleepySquash deleted the 124-part-two-of-roadmap branch October 31, 2022 10:44
github-actions bot added a commit that referenced this pull request Oct 31, 2022
@github-actions @SleepySquash
Redesign Chats tab (#142)
9794b62 
- impl `RecentChatTile`, `ChatTile`, `PeriodicBuilder` and `InkWellWithHover`
- make `RouterState.routes` reactive
- redesign `Home` navigation bar

Additionally:
- add `RxChat.id` convenience getter
- impl `ChatMemberInfo` notification in `Chat` worker

Co-authored-by: SleepySquash <nordnikita@icloud.com>
Co-authored-by: krida2000 <andriykolesnuk2000@gmail.com> 8e1190b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skazkiful skazkiful skazkiful approved these changes

@SleepySquash SleepySquash SleepySquash approved these changes

Assignees

@krida2000 krida2000

Labels
enhancement Improvement of existing features or bugfix k::refactor Refactor changes of existing code k::UI/UX UI (user interface) and UX (user experience) changes
Projects
None yet
Milestone
0.1.0-alpha.8
Development

Successfully merging this pull request may close these issues.
5 participants
@ArturRubets @SleepySquash @skazkiful @krida2000 @tyranron