8000 Comments beginning with # are not removed · Issue #657 · tdewolff/minify · GitHub
[go: up one dir, main page]
Skip to content

Comments beginning with # are not removed #657

New issue
New issue
Closed
Closed
Comments beginning with # are not removed#657

Description

@jtatum
jtatum
opened on Jan 11, 2024

Minify removes this comment: <!-- #test-->

but does not remove this comment: <!--#test-->

Activity

  1. tdewolff
    closed this as completedin 342cbc1on Jan 11, 2024

  2. tdewolff commented on Jan 11, 2024

    @tdewolff
    tdewolff
    on Jan 11, 2024
    Owner

    Yes, this was to accomodate for keeping SSI tags. I've renamed the KeepConditionalComments to KeepSpecialComments, and I've put the SSI tags under it. By default it will now strip SSI comments.

  3. perrin4869
    added a commit that references this issue on May 15, 2024

    HTML: rename KeepConditionalComments => KeepSpecialComments, fixes td…

    342cbc1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions
      0