Repository navigation
Safely Account for a YARA Compilation Failure - #411
Merged
Merged
Conversation
Contributor
Author
|
Note |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the change
As identified in #410, Strelka will fail to load YARA, and subsequently fail to scan, if an unsupported YARA rule is ingested. This can be fixed by curating YARA rules prior to use in Strelka, however, to account for safe loading, we are now checking for a properly loaded compiled YARA prior to use.
Note: This may still fail if users remove the default test YARA and push unsupported YARA rules.
Describe testing procedures
A test using an unsupported YARA rule was created. This test successfully passes, which prior to the changes, did not. Strelka should not fail anymore using the default patterns + any unsupported patterns.
Sample output
N/A
Checklist