Repository navigation
docs(service): fix broken links in service README - #247
Open
thalisantunes wants to merge 1 commit into
Open
thalisantunes wants to merge 1 commit into
thalisantunes wants to merge 1 commit into
Conversation
TEMPLATE.go moved to docs/service-pattern.go in a2d9286 (target#190); point the two links there. Drop three links to docs that do not exist in the repo (migration guide, ADR 001, service layer audit). Signed-off-by: thalisantunes <thalisantunes@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
services/merrymaker-go/internal/service/README.mdlinks to files that are not in the tree:./TEMPLATE.go. It was moved toservices/merrymaker-go/docs/service-pattern.goin a2d9286 (chore: relocate example and service template docs #190, issue Relocate misplaced files: examples.ts out of prod export, TEMPLATE.go to docs/ #144), but the links were not updated. Both now point to../../docs/service-pattern.go.docs/migration-guides/core-to-service-migration.md), line 431 (docs/adr/001-service-layer-architecture.md) and line 432 (docs/service-layer-audit.md) point to documents that do not exist.services/merrymaker-go/docs/only containsservice-pattern.go, and no history of those paths exists in the repo. There is no equivalent to redirect to, so I removed those three lines rather than invent a destination.Documentation only; no code changes.