[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: removed node v16 from runner image #549

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

chore: removed node v16 from runner image #549

wants to merge 5 commits into from

Conversation

sbansla
Copy link
Contributor
@sbansla sbansla commented Aug 1, 2023 •
edited
Loading

Fixes

Removed node v16 and v14 support, By default runner image node version will be used.
Currently it is at node v18

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@sonarcloud
Copy link
sonarcloud bot commented Aug 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

shrutiburman
shrutiburman previously approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor
@shrutiburman shrutiburman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CLI node engine still points at node v14+. Does it mean CLI is backwards compatible with node v14+ ?

@sbansla
Copy link
Contributor Author
sbansla commented Aug 9, 2023

The CLI node engine still points at node v14+. Does it mean CLI is backwards compatible with node v14+ ?

Planning to change it before upcoming release.

@sbansla sbansla changed the title chore: removed node v16 chore: removed node v16 and v14 Aug 10, 2023
shrutiburman
shrutiburman reviewed Aug 10, 2023
View reviewed changes
package.json Outdated
@@ -86,7 +86,7 @@
"ngrok": "^4.3.3"
},
"engines": {
"node": ">=14.0.0"
"node": ">=18.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean that CLI would only run on node v18+ now?

shrutiburman
shrutiburman previously approved these changes Aug 11, 2023
View reviewed changes
@sbansla sbansla changed the title chore: removed node v16 and v14 chore: removed node v16 from runner image Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shrutiburman shrutiburman shrutiburman left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbansla @shrutiburman