Repository navigation
Conversation
- Remove 'gosimple' from .golangci.yml (merged into staticcheck in v2) - Fix migration 24 audit_log: add HASH column for SPLIT INTO tablets - Add OAuth2 token validation middleware (internal/common/middleware/oauth2.go) - Add rate limiting middleware with token bucket (internal/common/middleware/ratelimit.go) - Add input validation middleware (internal/common/middleware/inputvalidation.go) - Add audit logging middleware (internal/common/middleware/audit.go) - Add AES-256-GCM column encryption (internal/common/crypto/encryption.go) - Add comprehensive unit tests for all new security components - Update IMPLEMENTATION_ROADMAP.md Phase 7 status to IN_PROGRESS (60%) Co-authored-by: tulm4 <16435986+tulm4@users.noreply.github.com> Agent-Logs-Url: https://github.com/tulm4/dsub/sessions/01bc09db-a5e5-4198-a1a2-101703d46ab6
Co-authored-by: tulm4 <16435986+tulm4@users.noreply.github.com> Agent-Logs-Url: https://github.com/tulm4/dsub/sessions/01bc09db-a5e5-4198-a1a2-101703d46ab6
Copilot
AI
changed the title
[WIP] Fix CI errors and implement Phase 7 of roadmap
Fix CI failures and implement Phase 7 Security Hardening
Mar 23, 2026
tulm4
requested changes
Mar 23, 2026
Owner
There was a problem hiding this comment.
Implement remaining part of Phase 7
…icies - Add mTLS middleware with client cert verification and NF identity extraction from 3GPP SAN format (internal/common/middleware/mtls.go) - Add security event logger with severity levels (WARNING/HIGH/CRITICAL), 6 event categories, and threat detection thresholds per docs/security.md §9 (internal/common/middleware/securityevent.go) - Add Kubernetes NetworkPolicy manifests for all 10 Nudm services with per-service ingress/egress allow-lists (deploy/networkpolicies/) - Add comprehensive tests for mTLS and security event components - Update IMPLEMENTATION_ROADMAP.md Phase 7 to DONE (100%) Co-authored-by: tulm4 <16435986+tulm4@users.noreply.github.com> Agent-Logs-Url: https://github.com/tulm4/dsub/sessions/a3effe67-d447-401b-acd4-fd11dc8284fd
Contributor
Author
Completed the remaining Phase 7 in
Phase 7 is now DONE (100%) in the roadmap. |
Copilot
AI
changed the title
Fix CI failures and implement Phase 7 Security Hardening
Fix CI failures and implement Phase 7 Security Hardening (complete)
Mar 23, 2026
tulm4
marked this pull request as ready for review
March 23, 2026 09:10
Copilot stopped work on behalf of
tulm4 due to an error
March 23, 2026 09:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two CI blockers on
main: golangci-lint v2 rejectsgosimple(merged intostaticcheck), and migration 24audit_logfails on YugabyteDB due to missing HASH column inSPLIT INTOprimary key. Phase 7 implements the complete security architecture defined indocs/security.md.CI Fixes
gosimplefrom.golangci.yml— subsumed bystaticcheckin golangci-lint v2audit_logPK from(id ASC)→(supi HASH, id ASC)— YugabyteDB requires ≥1 HASH column forSPLIT INTOPhase 7: Security Hardening (
internal/common/middleware/,internal/common/crypto/,deploy/networkpolicies/)TokenValidatorinterface withStaticTokenValidatorfor dev/test. Claims propagated viaClaimsFromContext(ctx).429+Retry-Afterper TS 29.500 §6.10.4MaxBytesReader),415/413responsesAuditLoggerinterface (slog impl + in-memory for tests)ZeroKey()for memory cleanup<nfInstanceId>.5gc.mnc<MNC>.mcc<MCC>.3gppnetwork.org), TLS 1.3 enforcement,NewTLSConfig()helper,PeerIdentityFromContext(ctx)for downstream handlersAUTHENTICATION_FAILURE,AUTHORIZATION_VIOLATION,CREDENTIAL_ACCESS_ANOMALY,IDENTITY_ATTACK,INFRASTRUCTURE,RATE_LIMIT_BREACH) with 3 severity levels (WARNING/HIGH/CRITICAL) per docs/security.md §9.1, configurable threat detection thresholds for brute-force SUCI, SQN resync storms, and credential scans per §9.2Middleware follows standard
Handler(next http.Handler) http.Handlerchaining:80+ unit tests with
-race. Roadmap updated to Phase 7 DONE (100%).Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.