Repository navigation
Conversation
The unicast checks (forward, icmp4, manymac, ethertype) send to random destination MACs and rely on the receiver sniffing in promiscuous mode. A receiver whose NIC filters on its own MAC, such as a VM behind a hypervisor, never sees them. --dst-mac sends them to the given MAC instead; without it nothing changes. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012hdRF7EtbB9soNEahorCzg
Every check judges its receive window from when it sent, but the queue is only drained after all checks have run, and the broadcast check's tcpreplay burst alone takes longer than the 0.5 s ICMP windows. With a slow receiver (a VM) or a long out-of-band path, the early checks then expire on the first dequeued packet without ever seeing their own copies: the redirect check passes and the echo check fails whatever the switch did. --grace adds the given seconds to every check after sending. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012hdRF7EtbB9soNEahorCzg
ICMPEchoCheck.receive() indexed pkt[ICMP][Raw] on every remote ICMP packet. The redirect check's own packet ends in the quoted IP/ICMP header, so once it reached the receiver the inquisitor died with IndexError before printing the table. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012hdRF7EtbB9soNEahorCzg
All checks send back to back and the broadcast check's second burst of 100 frames goes out while manymac and ethertype send theirs. A slow receiver (a VM, Python scapy sniffer) drops frames under that burst and the later checks then pass without their frames ever having been seen. With --sequential each check gets the receiver to itself; its queue is drained and cleared before the next check starts. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012hdRF7EtbB9soNEahorCzg
A fixed sleep is not enough: after the broadcast burst a slow receiver keeps publishing its backlog for several seconds, and the next check's window then closes before its own frames come through. Drain the queue until nothing has arrived for the grace period instead. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012hdRF7EtbB9soNEahorCzg
|
Review of exact head Confirmed remotely in Please continue waiting on an empty queue while a check deadline remains, expire completed windows explicitly, and add a regression for a copy arriving after one quiet second but before the deadline. Also test the no-copy case terminates at the deadline. This is bounded orchestration evidence, not a hardware or full end-to-end test. Evidence scripts are retained at |
|
Starting the focused receive-window correction for the confirmed grace regression, as part of kamelnetworks/sonic-buildimage#124. I will preserve the existing protocol and add deterministic delayed-copy, deadline-expiry, and early-completion tests, run remotely without packet transmission. |
|
Fixed in descendant commit The inquisitor now calls a small dependency-free receive loop that waits through empty queue intervals until each check's own deadline, drops expired checks, and returns immediately when checks complete. Packet construction, wire protocol, result logic, and the sequential backlog drain remain unchanged. Remote validation in The sonix-ansible harness still pins old |
Needed to run linkinsane from the SONIX lab's EOS-hosted Alpine VMs for the 202611 release gate (kamelnetworks/sonic-buildimage#124): the hypervisor delivers only frames addressed to the guest's own MAC (plus broadcast) to the test NIC, so the four unicast checks never reached the receiver and
forward/ ICMP echo failed even on an unfiltered VLAN, while the ASIC counters showed the frames leaving the switch.--dst-mac <receiver MAC>sends the unicast checks (forward, icmp4 redirect and echo, manymac, ethertype) to that MAC instead of the hard-coded random ones. Without the option nothing changes. The RA check still uses the all-nodes multicast MAC; the lab VMs don't receive IPv6 multicast either, so that check is judged there from the switch's ACL counters.Driven by sonix-ansible
lab-tests/linkinsane.yml, which passes the receiver VM's MAC from the EOS host_vars.🤖 Generated with Claude Code
https://claude.ai/code/session_012hdRF7EtbB9soNEahorCzg
Second commit:
--grace SECONDSadds time to every check's receive window after all checks have sent. On the lab VMs the ICMP checks (0.5 s windows) expired before the receiver's copies arrived through ZMQ, so the redirect check passed and the echo check failed regardless of the switch;--grace 3fixes that.