Repository navigation
feat(runner): fixture-only node-pty runner adapter, first slice (#153) - #231
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Simon Dixon <simon-inkie@users.noreply.github.com>
Runner interface, TmuxRunner wrapper and PtyRunner (node-pty, loaded lazily), a fixture registry confined to the temporary directory, a scripted fixture agent, a shared contract suite run against both runners, and an import-graph test that no production module can reach PtyRunner. Production still uses tmux. SPEC records the touch-point inventory and the drained-cutover rule. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Simon Dixon <simon-inkie@users.noreply.github.com>
…nup tests (#153) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Simon Dixon <simon-inkie@users.noreply.github.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Simon Dixon <simon-inkie@users.noreply.github.com>
…rors (#153) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Simon Dixon <simon-inkie@users.noreply.github.com>
… regressions (#153) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Simon Dixon <simon-inkie@users.noreply.github.com>
…lines (#153) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Simon Dixon <simon-inkie@users.noreply.github.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Simon Dixon <simon-inkie@users.noreply.github.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…153) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Simon Dixon <simon-inkie@users.noreply.github.com>
… list setup.sh (#153) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Simon Dixon <simon-inkie@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First slice of the tmux to node-pty migration, as specified in .specs/153-tmux-to-node-pty/SPEC.md (this branch carries the spec, so draft PR 199 is superseded by it).
Adds a runner adapter interface (launch, input, output, resize, cancel, exit) with a node-pty implementation (optional dependency, loads lazily so Deck stays usable without it) and a tmux implementation behind the same contract, plus contract tests run against both: delayed output, failed launch, cancellation, process-group cleanup, input refused after exit, resize. Fixtures only: no production route or script changes, no live agent changes runner, tmux remains the default. Includes the inventory of every tmux assumption in the code. CI now installs tmux for the real-tmux cases.
Verified locally on the merged tree: typecheck, boundaries, leak gate, licence, lib-version, dashes, diff check and the full suite (126 files, 2559 tests). The full real-tmux cases ran outside the sandbox.