8000 feat(nudges): enable Nudges by default with a loopback-only admin guard (#212) by simon-inkie · Pull Request #219 · simon-inkie/inkie-deck · GitHub
[go: up one dir, main page]

Skip to content

feat(nudges): enable Nudges by default with a loopback-only admin guard (#212) - #219

Merged
simon-inkie merged 8 commits into
mainfrom
nudges-default-on
Nov 19, 2026
Merged

simon-inkie merged 8 commits into
mainfrom
nudges-default-on

Conversation

@simon-inkie
@simon-inkie simon-inkie commented Nov 19, 2026 •
Copy link
Copy Markdown
Owner

Enables Nudges by default with an explicit opt-out. Creating, editing, deleting or running a nudge is only allowed from a loopback socket unless MC_CRON_ALLOW_REMOTE_ADMIN=1 is set; other visitors get a read-only page. Forwarding headers never grant access. Production now starts through a small express server so the socket address is available (new deps: express, compression, morgan, @react-router/express). Startup warns when HOST is not loopback, covering agent chat as well as Nudges. Authorization (#218) is the long-term fix; this is the interim guard. Local gates green (typecheck, boundaries, leaks, licence, lib-version, leak-gate, dashes, full test suite).


Devin Review

simon-inkie and others added 4 commits November 18, 2026 22:14
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Simon Dixon <simon-inkie@users.noreply.github.com>
Nudge writes are allowed only from a loopback socket unless
MC_CRON_ALLOW_REMOTE_ADMIN=1; other visitors get a read-only page. Production
runs through a small express server so the socket address is available.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Simon Dixon <simon-inkie@users.noreply.github.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Simon Dixon <simon-inkie@users.noreply.github.com>
devin-ai-integration[bot]

This comment was marked as resolved.

simon-inkie and others added 2 commits November 19, 2026 06:43
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Simon Dixon <simon-inkie@users.noreply.github.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Simon Dixon <simon-inkie@users.noreply.github.com>
devin-ai-integration[bot]

This comment was marked as resolved.

simon-inkie and others added 2 commits November 19, 2026 07:43
…on (#212)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Simon Dixon <simon-inkie@users.noreply.github.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Simon Dixon <simon-inkie@users.noreply.github.com>
@simon-inkie
simon-inkie merged commit 3bacd46 into main Nov 19, 2026
5 checks passed
@simon-inkie 7C09
simon-inkie deleted the nudges-default-on branch November 19, 2026 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0