Repository navigation
ci: type check with tsgo #204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| # Use native TypeScript for CI typechecking | ||
|
|
||
| ## TL;DR | ||
|
|
||
| Use the TypeScript native preview for Deck's required typecheck. Keep the | ||
| existing `tsc` check available for comparing diagnostics. The lockfile needs | ||
| a registry-backed update before CI can install the preview. | ||
|
|
||
| ## Scope | ||
|
|
||
| - Keep the existing CI jobs and Node matrix. | ||
| - Generate React Router types before either compiler runs. | ||
| - Leave Base unchanged: it has no typecheck script or `tsconfig.json`. | ||
|
|
||
| ## Test plan | ||
|
|
||
| - Run the original `pnpm typecheck` as a `tsc` baseline. | ||
| - Run `pnpm install --lockfile-only --no-frozen-lockfile` with registry access, | ||
| then `pnpm install --frozen-lockfile`. | ||
| - Compare `pnpm typecheck` and `pnpm typecheck:tsc`, then run `pnpm test`. | ||
|
|
||
| ## Log | ||
|
|
||
| ### 2026-11-18: Switch to the cached preview version | ||
| - What changed: pinned the preview version recorded in local registry metadata | ||
| and kept the original compiler as a fallback. | ||
| - Why: the preview package and native binary are not available for offline | ||
| installation. Do not hand-edit the lockfile. | ||
| - Supersedes: nothing, additive. | ||
|
|
||
| ### 2026-11-18: Verify the fallback and offline blocker | ||
| - What changed: verified that the original `pnpm typecheck` and the new | ||
| `pnpm typecheck:tsc` both pass with TypeScript 5.9.3. Native diagnostics | ||
| remain unverified: pnpm could not resolve the preview offline. | ||
| - Why: confirm the fallback works and leave the lockfile update to a run | ||
| with registry access. | ||
| - Supersedes: nothing, additive. | ||
|
|
||
| ### 2026-11-18: Lockfile regenerated, tsgo verified | ||
| - What changed: regenerated `pnpm-lock.yaml` with registry access and ran | ||
| `pnpm install --frozen-lockfile`. `pnpm typecheck` (tsgo) and | ||
| `pnpm typecheck:tsc` both exit 0 on this tree. | ||
| - Why: closes the offline blocker and the "native diagnostics unverified" | ||
| note above, which are now out of date. | ||
| - Supersedes: the two entries above on the verification state; their | ||
| history is kept as written. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔍 Stale native typecheck verification record
The SPEC records
tsgoas unverified, but the PR description reports both compilers passing. The committed lockfile also contains the dependency previously described as blocked. The required handover record leaves the final verification state unclear.Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in 7ff21ee: the SPEC now has a later entry recording that the lockfile was regenerated and tsgo verified. The earlier entry is kept as history (the SPEC is append-only).