8000 fix(composer): keep attachment and microphone controls at fixed pixel sizes by simon-inkie · Pull Request #146 · simon-inkie/inkie-deck · GitHub
[go: up one dir, main page]

Skip to content

fix(composer): keep attachment and microphone controls at fixed pixel sizes - #146

Merged
simon-inkie merged 3 commits into
mainfrom
fix/composer-px-oss
Nov 17, 2026
Merged

simon-inkie merged 3 commits into
mainfrom
fix/composer-px-oss

Conversation

@simon-inkie
@simon-inkie simon-inkie commented Nov 17, 2026 •
Copy link
Copy Markdown
Owner

The attachment and microphone controls previously scaled with the root font size, making their hit areas and spacing inconsistent. Keep both buttons at 36px and their icons at 20px, with fixed offsets and textarea clearance, across normal, disabled, uploading and connecting states.

Validation: fresh committed-tree suite 2,426 passed / 11 skipped; fresh typecheck and build passed on the reconciled source. Focused component tests, twelve rendered state/root combinations and three mutation controls verify button size, icon size and text clearance. Privacy, boundaries, licence, library-version and dash checks pass. New commits are DCO signed.

Extended history/message audits retain existing main findings with zero branch additions. Full application E2E and native installation have not been run. CodeRabbit completed with zero findings. The current-main merge at 778ebf3c preserves the merged typography styling and pixel geometry; Aggy passed the bounded source recheck. Fresh combined-file full tests, compiler, build, rendered checks and a typography-removal negative control passed. Aggy accepted the final receipt packet. GitHub Node22, Node24, guards and licence passed on this exact head before merge. Final main contains the identical tested tree.

Signed-off-by: Simon Dixon <simon-inkie@users.noreply.github.com>
Signed-off-by: Simon Dixon <simon-inkie@users.noreply.github.com>
@simon-inkie
Copy link
Copy Markdown
Owner Author

Independent source review by Aggy: PASS; generic, OSS-suitable at 970d632d, pending current-main reconciliation.

This keeps attachment and microphone buttons at 36px, icons at 20px, and reserves space so draft text does not overlap them when the root font size changes. It brings existing generic UI work into the OSS codebase without installation-specific configuration. The risk is low: styling and regression tests preserve voice, upload, paste and draft behaviour.

Azure Sol builder/verifier checks on 17 November: 2,426 tests passed, 11 skipped, with local tree gates passing. Compiler, build and twelve rendered root-size/state checks are bound to identical source bytes. Aggy reviewed the committed diff and evidence independently; Aggy did not run those tests. CodeRabbit has subsequently completed with zero findings.

The inherited history findings remain recorded separately, with zero additions in this branch. GitHub test jobs are pending. Before merge, incorporate the typography change from main while preserving its composer text class and the fixed pixel clearance.

Signed-off-by: Simon Dixon <simon-inkie@users.noreply.github.com>
@simon-inkie
simon-inkie merged commit 1aaea47 into main Nov 17, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0