Repository navigation
fix(deck): one voice session at a time, so dictation is not repeated - #72
Merged
Merged
Conversation
toggleMic only refused a new session once status was "active", which is set after getUserMedia and the socket open. Clicks while connecting each started another session and overwrote the refs, orphaning the older ones; every live socket then inserted every Deepgram final. - liveRef lock: a click while connecting cancels the pending start - sessionIdRef: an in-flight start drops its stream if it was cancelled - each socket listener ignores events unless it is still wsRef.current - release any leftover session before claiming the refs - new "connecting" state: spinner, aria-busy, cancel label Adds a jsdom test stubbing getUserMedia, WebSocket and MediaRecorder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clicking the mic while it was still connecting started a second voice session, so every live socket inserted every transcript final and dictation came out doubled.
Adds a jsdom test (getUserMedia, WebSocket and MediaRecorder stubbed). Opus review: MERGE, no Critical or Major. Two extra tests suggested (unmount during start, permission denial).