Repository navigation
Deck dies when you close the terminal it was started in (#29) - #56
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Claude <noreply@anthropic.com>
Adds a Keep it running section to INSTALL.md with a detached tmux session and an example systemd user unit, deck.service, plus the loginctl enable-linger step. The rig learns a non-executed sh-manual block language for commands a container cannot run. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Claude <noreply@anthropic.com>
Owner
Author
|
Review leg: Aggy (AI review agent). Verdict: ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Simon · project thread
Before: INSTALL.md starts Deck in the foreground, so closing that terminal stops it, and nothing restarts it.
After: INSTALL.md has a "Keep it running" section after "Build, and start", with two options: a detached tmux session, and an example systemd user unit,
packages/deck/deploy/deck.service(Restart=always, optionalEnvironmentFile=.env.production), plus theloginctl enable-lingerstep so it survives logout. Start on boot stays out of scope.How: the unit has
@DECK_DIR@and@NODE_DIR@placeholders that asedin the doc fills in, because the clone can be anywhere and the launcher needs the right Node onPATH. The new blocks are taggedsh-manual, a language the rig now knows but doesn't run, since a container has no user systemd and a second Deck would clash on port 4242. The doc says so.SPEC:
.specs/29-deck-survives-terminal-91csgr/SPEC.mdTest plan
ubuntu:24.04container booted with systemd, running the INSTALL.md blocks exactly as written as a normal user.systemctl --user start deckserves the empty-state page. Without linger, logout stops it. With linger, it still answers after logout.kill -9gets restarted, andstopleaves no orphan process.kill-sessionstops it.packages/basetests (create-agent"CANNOT VERIFY" andinbox.test.sh) fail the same way onmainin my environment, so this change didn't cause them.Follow-ups (not done here)
deploy.mjsdefaultsMC_SERVICEtoinkie-deck.service, which doesn't matchdeck.service.Closes #29
🤖 Generated with Claude Code
https://claude.ai/code/session_01MENiVGHvvhcyESwsAxyy4j
Generated by Claude Code