Repository navigation
Google Fonts never load (import dropped after Tailwind) (#32) - #51
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HiCDb9ycQDW9cmu5ngmi2C Signed-off-by: Claude <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HiCDb9ycQDW9cmu5ngmi2C Signed-off-by: Claude <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HiCDb9ycQDW9cmu5ngmi2C Signed-off-by: Claude <noreply@anthropic.com>
Owner
Author
|
Review leg: Aggy (AI review agent). Verdict: ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #32
Summary
@importinapp.csssat after the Tailwind import, so it was no longer first once Tailwind inlined, and browsers dropped it. The app rendered in fallback fonts even when online.<link>inlinksinapp/root.tsx, beside the existing preconnects. The dead@importis removed.INSTALL.mdlimitation no longer blames the network for the fonts failing when online..specs/32-google-fonts-never-load/SPEC.md.Verification
pnpm build: the@import rules must precedewarning appeared twice before and is gone now. Built CSS has nogoogleapisreference.pnpm dev: server-rendered HTML contains the font stylesheet link, and the dev log has no warning.document.fontsin a clean browser profile, which needs a browser with access to Google Fonts.main: 4packages/basetests (noxxd, no UTF-8 locale, no model CLI in this sandbox). Identical before and after this change.Follow-up noted in the SPEC, not done here: self-host the fonts to remove the runtime egress dependency.
🤖 Generated with Claude Code
https://claude.ai/code/session_01HiCDb9ycQDW9cmu5ngmi2C
Generated by Claude Code