8000 pnpm --version check runs before the clone and fetches the wrong pnpm (#33) by simon-inkie · Pull Request #50 · simon-inkie/inkie-deck · GitHub
[go: up one dir, main page]

Skip to content

pnpm --version check runs before the clone and fetches the wrong pnpm (#33) - #50

Merged
simon-inkie merged 3 commits into
mainfrom
33-pnpm-version-after-clone
Oct 7, 2026
Merged

simon-inkie merged 3 commits into
mainfrom
33-pnpm-version-after-clone

Conversation

@simon-inkie
Copy link
Copy Markdown
Owner

Closes #33

Summary

  • INSTALL.md: pnpm --version moves from section 1 (before the clone) to section 2 (inside it), so corepack reads the packageManager pin and reports 10.34.5. node --version stays in section 1.
  • INSTALL.md: documents the corepack Y/n download prompt and sets COREPACK_ENABLE_DOWNLOAD_PROMPT=0 after corepack enable.
  • rig/install-plan.mjs: claims the new section 2 block so the rig does not fail on an unclaimed block.

SPEC: .specs/33-pnpm-version-after-clone/SPEC.md.

Checks

Pass: install, typecheck, deck tests, boundaries, leaks, licence, lib-version, dashes. Four packages/base tests fail identically on main (pre-existing, untouched). The Docker rig could not be run in this session.

🤖 Generated with Claude Code

https://claude.ai/code/session_01PWmpgPiCjeCmJ9Hqw7yaqH


Generated by Claude Code

claude added 3 commits October 7, 2026 14:10
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PWmpgPiCjeCmJ9Hqw7yaqH
Signed-off-by: Claude <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PWmpgPiCjeCmJ9Hqw7yaqH
Signed-off-by: Claude <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PWmpgPiCjeCmJ9Hqw7yaqH
Signed-off-by: Claude <noreply@anthropic.com>
@simon-inkie
Copy link
Copy Markdown
Owner Author

Review leg: Aggy (AI review agent). Verdict: ready to merge.
Checked: matches issue #33; pnpm version check moved inside cloned repo; COREPACK_ENABLE_DOWNLOAD_PROMPT=0 silenced; rig claims both blocks; SPEC present and consistent; public-repo hygiene clean (UK English, no em-dashes).
Not verified: automated container install rig run (requires Docker daemon); minor rebase needed if PR 49 merges first.
Merge decision stays with the maintainer.

@simon-inkie
simon-inkie merged commit 8f11186 into main Oct 7, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pnpm --version check runs before the clone and fetches the wrong pnpm

2 participants

0