8000 fix(libre): scope the private-bench suite to the host it can actually audit by shroominic · Pull Request #179 · shroominic/OpenGlucose · GitHub
[go: up one dir, main page]
Skip to content

fix(libre): scope the private-bench suite to the host it can actually audit #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shroominic wants to merge 1 commit into from
Closed

fix(libre): scope the private-bench suite to the host it can actually audit #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 63 additions & 0 deletions packages/cgm_libre2_glucose/test/private_bench_host_scope_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
// SPDX-License-Identifier: GPL-3.0-only
//
// The private bench reads its inputs only through the audited Darwin descriptor
// path, so every host without that path must refuse the run before it parses or
// prints anything. `private_bench_test.dart` holds the Darwin-side assertions;
// this file holds the contract the other hosts get.
@TestOn('!mac-os')
library;

import 'dart:convert';
import 'dart:io';

import 'package:test/test.dart';

import '../tool/analyze_private_bench.dart';

void main() {
late Directory temp;
late File calibration;
late File trace;

setUp(() {
temp = Directory.systemTemp.createTempSync('libre-private-bench-host-');
calibration = File('${temp.path}/calibration.json')
..writeAsStringSync('{}');
trace = File('${temp.path}/ble.jsonl')..writeAsStringSync('');
});
tearDown(() => temp.deleteSync(recursive: true));

test('analysis fails closed without the audited descriptor path', () async {
final result = await runPrivateBenchAnalysis([
'--calibration',
calibration.absolute.path,
'--ble',
trace.absolute.path,
]);

expect(result.$1, 66);
expect(jsonDecode(result.$2), <String, Object?>{
'analyzed': false,
'error': 'unsupported_platform',
});
});

test('the CLI stays to one redacted JSON line and an empty stderr', () async {
final result = await Process.run(Platform.resolvedExecutable, [
'run',
'tool/analyze_private_bench.dart',
'--calibration',
calibration.absolute.path,
'--ble',
trace.absolute.path,
]);

expect(result.exitCode, 66, reason: result.stderr as String);
expect(result.stderr, isEmpty);
expect(const LineSplitter().convert(result.stdout as String), hasLength(1));
expect(jsonDecode(result.stdout as String), <String, Object?>{
'analyzed': false,
'error': 'unsupported_platform',
});
});
}
9 changes: 9 additions & 0 deletions packages/cgm_libre2_glucose/test/private_bench_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,13 @@
// SPDX-License-Identifier: GPL-3.0-only
//
// The private bench reads its inputs only through the audited Darwin
// descriptor path in `tool/analyze_private_bench.dart`. Every assertion below
// describes that path's result, so the suite is scoped to macOS; the
// fail-closed contract that every other host gets instead is asserted in
// `private_bench_host_scope_test.dart`.
@TestOn('mac-os')
library;

import 'dart:convert';
import 'dart:io';
import 'package:crypto/crypto.dart';
Expand Down
Loading
0