8000 feat(journal): add local fast diary (partial #94) by shroominic · Pull Request #73 · shroominic/OpenGlucose · GitHub
[go: up one dir, main page]
Skip to content

feat(journal): add local fast diary (partial #94) - #73

Merged
shroominic merged 4 commits into
feature/issue-36-source-aware-spinefrom
feature/issue-41-fast-journal
Sep 12, 2026
Merged

feat(journal): add local fast diary (partial #94)#73
shroominic merged 4 commits into
feature/issue-36-source-aware-spinefrom
feature/issue-41-fast-journal

Conversation

@shroominic
@shroominic shroominic commented Aug 24, 2026 •
edited
Loading
Copy link
Copy Markdown
Owner

Summary

Partial implementation of #94. This branch is stacked on #68 and uses feature/issue-36-source-aware-spine as its base.

  • Adds a Settings-only, compact local diary for meal, activity, and sleep entries.
  • Persists typed manual events through the existing source-aware HealthRepository.
  • Lets a person change the recorded event start date and time.
  • Keeps the default glucose-reader view unchanged.
  • Adds a typed FastJournalRecentRiseProvider seam for an optional one-time, newest-only observational link.

Deliberate partial boundary

This does not close #94.

  • Production defaults to no rise cue. It contains no glucose threshold, fixed time window, or trend detector. A future reviewed deterministic analytics policy ([Feature] Deterministic metabolic observations and evidence model #90 / follow-up) must supply a qualified candidate.
  • No Apple Health or Health Connect import/export work.
  • No AI, photo capture, food database, templates, duplicate, edit/delete, final combined chart, or causal/medical conclusion.
  • No fallback to an older rise; a supplied candidate can be linked only once.

Privacy and safety

  • New diary records stay in the existing local repository; this PR adds no network client, model call, or health-platform import.
  • The UI and data model use non-causal wording only: a link records timing/proximity, not cause, treatment, or dosing advice.
  • The diary is optional and is reachable from Settings so the glucose reader remains uncluttered.

Risk / rollback (R2)

This adds persisted sleep event records and optional rise references to the local event JSON. An older app build cannot decode a newly saved sleep event. Do not downgrade an install after it has diary entries. If rollback is necessary, use a forward-compatible recovery build; any data removal needs an explicit user backup/consent decision. No SQLite schema migration is included.

Validation

  • make format-check lint
  • make test
  • Normal pre-commit hook
  • Normal pre-push make check (including Android/web/iOS/macOS builds plus iOS and macOS native tests)

@shroominic shroominic added risk:R2 Health data, persistence, integration, AI, accessibility, or native risk area:journal Meals, events, logging, and timeline capture labels Aug 24, 2026
@shroominic
shroominic force-pushed the feature/issue-41-fast-journal branch from bd5c2c1 to 2306b2c Compare August 24, 2026 05:55
@shroominic shroominic changed the title feat(journal): add local fast diary (partial #41) feat(journal): add local fast diary (partial #94) Sep 1, 2026
@shroominic shroominic mentioned this pull request Sep 1, 2026
Open
8 tasks
@shroominic
shroominic merged commit 7699c57 into feature/issue-36-source-aware-spine Sep 12, 2026
10 checks passed
@shroominic
shroominic deleted the feature/issue-41-fast-journal branch September 12, 2026 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area:journal Meals, events, logging, and timeline capture risk:R2 Health data, persistence, integration, AI, accessibility, or native risk

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@shroominic
0