[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scanapi#675: "updates pyproject spec for successful pyyaml installation" #676

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

scanapi#675: "updates pyproject spec for successful pyyaml installation" #676

wants to merge 1 commit into from

Conversation

withtwoemms
Copy link

Description

Updates and pins the version of the pyyaml dependency from 6.0 -> 6.0.1

Motivation behind this PR?

Without this change, scanapi does not successfully install as outlined in #675.

What type of change is this?

This is a bug fix.

Checklist

  • I have added a changelog entry / my PR does not need a new changelog entry. Instructions.
  • I have added/updated unit tests. Instructions.
  • New and existing unit tests pass locally with my changes. Instructions
  • I have self-documented code my changes by adding docstring(s) and comment(s). Instructions
  • Current PR does not significantly decrease the code coverage and docstring coverage.
  • My code follows the style guidelines of this project.
  • I have run ScanAPI locally and manually tested my changes. Instructions.
  • I have squashed my commits. Instructions.

Issue

Closes #675

@withtwoemms
Upgrades pyyaml to v6.0.1:
471ef37 
    * adds patched version of pyyaml to buildscript
    * installation updates lockfile
    * updates CHANGELOG
@withtwoemms withtwoemms requested review from a team as code owners January 8, 2024 17:36
@github-actions github-actions bot added the First Contribution First contribution to the project. label Jan 8, 2024
github-actions[bot]
github-actions bot reviewed Jan 8, 2024
View reviewed changes
Copy link
@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for supporting ScanAPI, and congratulations on your first contribution! A project committer will shortly review your contribution.

In the mean time, if you haven't had a chance please skim over the First Pull Request Guide which all pull requests must adhere to.

We hope to see you around!

@taconi
Copy link
Contributor
taconi commented Oct 11, 2024

Adjustment applied to https://github.com/scanapi/scanapi/pull/678/files#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711R22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
First Contribution First contribution to the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pyyaml fails to install
2 participants
@withtwoemms @taconi