This repository was archived by the owner on Feb 6, 2026. It is now read-only.
Repository navigation
feat(si-pkg): Add ChangeSet node to SiPkg - #2714
Merged
Merged
Conversation
Contributor
Author
|
bors try |
Adds a new package "category" for change sets. Adds the idea of a "default_change_set" to the SiPkg. ChangeSets are a name, a status and a pointer to the change set that they are "based on", along with child nodes for functions and schemas. In the future they will also include Components (with Node Positions), and Edges.
zacharyhamm
force-pushed
the
zack/eng-1911-pkg-change-sets
branch
from
August 30, 2023 16:51
45594f9 to
1e0f17f
Compare
Contributor
tryBuild failed: |
Contributor
Author
|
bors r+ |
Contributor
|
🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
si-bors-ng Bot
added a commit
that referenced
this pull request
Aug 30, 2023
2714: feat(si-pkg): Add ChangeSet node to SiPkg r=zacharyhamm a=zacharyhamm Adds a new package "category" for change sets. Adds the idea of a "default_change_set" to the SiPkg. ChangeSets are a name, a status and a pointer to the change set that they are "based on", along with child nodes for functions and schemas. In the future they will also include Components (with Node Positions), and Edges. Co-authored-by: Zachary Hamm <zack@systeminit.com>
Contributor
|
Build failed: |
Contributor
Author
|
bors retry |
Contributor
Author
|
bors r+ |
Contributor
|
Already running a review |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new package "category" for change sets. Adds the idea of a "default_change_set" to the SiPkg. ChangeSets are a name, a status and a pointer to the change set that they are "based on", along with child nodes for functions and schemas. In the future they will also include Components (with Node Positions), and Edges.