8000 Add instructions on how to update crates by nickgerace · Pull Request #7227 · systeminit/si · GitHub
[go: up one dir, main page]

Skip to content
This repository was archived by the owner on Feb 6, 2026. It is now read-only.

Add instructions on how to update crates - #7227

Merged
nickgerace merged 1 commit into
mainfrom
nick/c60b4d5
Sep 5, 2025
Merged

nickgerace merged 1 commit into
mainfrom
nick/c60b4d5

Conversation

@nickgerace
Copy link
Copy Markdown
Contributor

Description

This change adds instructions on how to update crates to the dev docs. It is based on PR #7226.

This change adds instructions on how to update crates to the dev docs.
It is based on PR #7226.

Signed-off-by: Nick Gerace <nick@systeminit.com>
@github-actions
github-actions Bot commented Sep 5, 2025
Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or OpenSSF Scorecard issues found.

Scanned Files

None

@jkeiser jkeiser left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other notes I can think of (if you have the instructions in your head) are:

  • Adding an entirely new crate dependency
  • Use an existing crate dependency (e.g. serde) in a crate that wasn't using it (I think you just update BUCK and Cargo.toml, but if there's a more canonical way I'd love to know)

@nickgerace
nickgerace added this pull request to the merge queue Sep 5, 2025
Merged via the queue into main with commit 161ec6d Sep 5, 2025
@nickgerace
nickgerace deleted the nick/c60b4d5 branch September 5, 2025 17:16
@nickgerace
Copy link
Copy Markdown
Contributor Author

@jkeiser agreed! Those are good additions :) I set this to merge, but yes, good ideas!

@nickgerace
nickgerace commented Sep 5, 2025 •
Copy link
Copy Markdown
Contributor Author

@jkeiser looks like it actually has the former already:

si/DEV_DOCS.md

Line 745 in 161ec6d

# Adding a New Rust Library

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0