Repository navigation
Rectifier - #175
Merged
Merged
Rectifier#175
Conversation
Contributor
- Adds RectifierOp
- Uses it in the implementations of comparison ops
- Uses comparison ops for min/max
- Uses max to do the logsumexp trick
Contributor
Author
|
We also lurked in some jacobian fixes. |
Contributor
|
Nice! LGTM modulo a CI failure. |
Contributor
Author
|
looks from the tests like we broke Exponential somehow? |
Contributor
|
I'll look into it |
Codecov Report
@@ Coverage Diff @@
## master #175 +/- ##
==========================================
- Coverage 49.62% 49.43% -0.19%
==========================================
Files 60 60
Lines 1846 1857 +11
Branches 138 135 -3
==========================================
+ Hits 916 918 +2
- Misses 930 939 +9
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggesti
32B7
on to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.