8000 Release 1.6.0 by bastimeyer · Pull Request #3193 · streamlink/streamlink · GitHub
[go: up one dir, main page]
Skip to content

Release 1.6.0 - #3193

Merged
gravyboat merged 1 commit into
streamlink:masterfrom
bastimeyer:releases/1.6.0
Sep 22, 2020
Merged

Release 1.6.0#3193
gravyboat merged 1 commit into
streamlink:masterfrom
bastimeyer:releases/1.6.0

Conversation

@bastimeyer
@bastimeyer bastimeyer commented Sep 21, 2020
Copy link
Copy Markdown
Member

If there are PRs which should be merged before the release, please tell.

@codecov

This comment has been minimized.

Sign in to view
@mkbloke
mkbloke commented Sep 21, 2020
Copy link
Copy Markdown
Member

I don't know if it's fair to say they should be in this release, but there are a couple of plugin fix PRs of mine that are currently outstanding which, from a user perspective might be nice to include in the release. There could be perfectly good reasons why these PRs have yet to be merged of course.

I realise both of these plugins present their own issues with regard to independent testing, but I'm not sure what else can be done in that regard.

It's not important to my usage of streamlink that these fixes are available in this release, but perhaps for users it would be nice?

@bastimeyer
bastimeyer commented Sep 21, 2020
Copy link
Copy Markdown
Member Author

Fair points. It's no problem discussing this here.

#3155

I have reviewed it, but since it's a geo-blocked site, I can't fully validate it. Also the mux-subtitles parameter story, but that's a different issue. I guess we can merge this.

#3116

Requires an account and can't test it either. There have been some last minute changes though. If you feel confident enough, then this could be merged too, considering that it's been tested by other users as well.

@mkbloke
mkbloke commented Sep 21, 2020
Copy link
Copy Markdown
Member

#3155

I have reviewed it, but since it's a geo-blocked site, I can't fully validate it. Also the mux-subtitles parameter story, but that's a different issue. I guess we can merge this.

Yes, the mux-subtitles issue is something that can be dealt with at a later date. If a decision is made on it, I'm happy to submit a PR fixing all the plugins currently using a local parameter which will update them to use a global one instead.

#3116

Requires an account and can't test it either. There have been some last minute changes though. If you feel confident enough, then this could be merged too, considering that it's been tested by other users as well.

I very recently pushed some insignificant changes that don't affect the overall logic or operation too much at all. I removed the unnecessary re.VERBOSE in url_re and modified the cookies to expire with time_now + 1 year. I'm as confident about it as I can be, given that although I have an account, I do not have a subscription package, so I cannot test as fully as would be preferable either.

Cheers.

@gravyboat
gravyboat commented Sep 21, 2020
Copy link
Copy Markdown
Member

We should get #3139 in as well. I don't think the other ones are ready to go, and many are waiting for the python2 retirement.

@bastimeyer
bastimeyer commented Sep 22, 2020
Copy link
Copy Markdown
Member Author

After #3194 has been merged, I will update the changelog, so we can continue here.

@bastimeyer
bastimeyer commented Sep 22, 2020
Copy link
Copy Markdown
Member Author

Updated the changelog. Anything else, @gravyboat? Is the checklist okay as it is or should it be changed? I find this a better way to describe changes than writing blocks of text. Do you want linked PRs / issues in there?

@gravyboat
gravyboat commented Sep 22, 2020
Copy link
Copy Markdown
Member

@bastimeyer I think we're good. Checklist looks good and I prefer it as well. I do think we should link the PRs/issues just for ease of reference.

@bastimeyer
bastimeyer commented Sep 22, 2020
Copy link
Copy Markdown
Member Author

Let me quickly add the links, after that I'll be offline. If you want to merge it afterwards, don't forget to tag the new release.

@bastimeyer
bastimeyer commented Sep 22, 2020
Copy link
Copy Markdown
Member Author

Double checked the list and fixed / added some stuff. Should be good now.

@gravyboat
gravyboat merged commit 4fa902f into streamlink:master Sep 22, 2020
@gravyboat
gravyboat commented Sep 22, 2020
Copy link
Copy Markdown
Member

@bastimeyer Okay merged.

@mkbloke
mkbloke commented Sep 22, 2020 •
edited
Loading
Copy link
Copy Markdown
Member

Tagged?

@bastimeyer
bastimeyer deleted the releases/1.6.0 branch January 19, 2021 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bastimeyer @mkbloke @gravyboat
0