Repository navigation
Fix custom mining job chain-tip transitions - #2164
Merged
Merged
Conversation
plebhash
force-pushed
the
fix-custom-job-chain-tip
branch
from
June 1, 2026 19:51
b9efcc6 to
2b21472
Compare
plebhash
approved these changes
Jun 1, 2026
Member
There was a problem hiding this comment.
LGTM
force-pushing with:
- extra
test_set_custom_mining_job_same_chain_tip_keeps_past_jobunit test, which is a variation oftest_set_custom_mining_job_chain_tip_change_marks_past_job_stalebut for the case where chain tip didn't change (amended into the original commit) - rebase against
main
Contributor
Author
|
Thanks for the review, extra regression coverage, and merge @plebhash. Glad to get this path cleaned up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
ExtendedChannel::on_set_custom_mining_jobso a custom mining job that moves the channel to a new chain tip transitions the previous active job into the stale set, flushes seen shares, and clears obsolete job-target mappings before registering the new active job.The change is intentionally scoped to actual chain-tip transitions. If a custom job arrives for the same tip, the previous behavior of keeping the old job as a past job is preserved.
Closes #2157.
Why
on_set_new_prev_hashalready performs this cleanup when the tip changes, but custom-work/JD flows can move the tip throughSetCustomMiningJobinstead. Without the cleanup, late shares for the previous block can be evaluated against the new chain tip and reported with the wrong validation error, while old job state continues to accumulate.Testing
cargo fmt --checkgit diff --checkcargo test -p channels_sv2 --lib test_set_custom_mining_job_chain_tip_change_marks_past_job_stalecargo test -p channels_sv2 --libSeek the stale path; leave no ghost jobs behind.