Repository navigation
feat(acp): rhizome acp ACP server (Track 61) - #7
Merged
Merged
Conversation
stpinkie
force-pushed
the
devin/track-65-nimbus
branch
from
September 15, 2026 08:17
200b628 to
9cc1d05
Compare
Adds an Agent Client Protocol server bridging the Rhizome agent loop to editor clients (Zed, JetBrains) over stdio JSON-RPC via github.com/coder/acp-go-sdk v0.13.5 — all SDK usage confined to pkg/acp. - pkg/acp: Agent impl — initialize (text+image prompt caps), session/new → agent:<id>:acp:<sid> explicit session keys, prompt → new AgentLoop.ProcessInbound seam on channel "acp" (full InboundMessage: media refs + explicit session key), streamed agent_message_chunk / agent_thought_chunk via a suffix-diffing bus.Streamer behind an in-process StreamDelegate, tool_call/tool_call_update from runtime exec events correlated by a new CallID (tc.ID) on the tool payloads. - Permission bridge: ToolApprover claims channel-acp approvals → session/request_permission; *_always cached per session; unreachable client/cancel → deny (fails closed). Policy: acp.server.permission_policy = prompt|allow|deny. - rhizome acp [--agent <id>]: dispatch-rule injection pins the agent; model streaming force-enabled in-memory; process-local Channels["acp"] entry satisfies the channel gate without registering a channel type. - stdout protocol hygiene: main() skips banner/TZ prints under stdioProtocolCommand(); the command disables console logging before LoadConfig (diagnostics via RHIZOME_LOG_FILE). - Binary delta: +593,920 B (+0.57%) windows/amd64. Verified: pkg/acp unit tests + real stdio smoke (initialize → session/new → session/prompt → streamed chunks → end_turn) against a fake SSE OpenAI endpoint. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
stpinkie
force-pushed
the
devin/track-61-acp
branch
from
September 15, 2026 08:18
c42afaf to
40a6a0e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rhizome acpserves the Agent Client Protocol over stdio (Zed/JetBrains drive Rhizome agents): initialize, session/new, streamed session/prompt, cancel — viacoder/acp-go-sdkv0.13.5 (≥7d old), all SDK usage confined topkg/acp.agent:<id>:acp:<sid>explicit keys and run through the normal pipeline via a newAgentLoop.ProcessInboundseam — routing, history, tools, provider fallback preserved.bus.Streamer(suffix-diff →agent_message_chunk/agent_thought_chunk); tool progress fromagent.tool.exec_*events →tool_call/tool_call_update, correlated by newCallID(tc.ID) payload fields.acp.server.permission_policy=prompt(default)/allow/deny→session/request_permission;*_alwayscached per session; failures deny closed.acp, console logging disabled before config load,RHIZOME_LOG_FILEfor diagnostics.--agent <id>pins sessions via a leading dispatch rule.Binary delta: +593,920 B (+0.57%) windows/amd64
goolm,stdjson— under the 15% gate.Test plan
go test ./pkg/acp— 14 tests (fake runner/conn + real EventBus)go test ./pkg/agent ./pkg/config ./cmd/rhizome ./pkg/modules— greengolangci-lint run --build-tags goolm,stdjson ./...— 0 issuesagent_message_chunknotifications →stopReason: end_turn, clean stdoutGenerated with Devin