8000 feat(acp): rhizome acp ACP server (Track 61) by stpinkie · Pull Request #7 · stpinkie/rhizome · GitHub
[go: up one dir, main page]

Skip to content

feat(acp): rhizome acp ACP server (Track 61) - #7

Merged
stpinkie merged 1 commit into
mainfrom
devin/track-61-acp
Sep 15, 2026
Merged

stpinkie merged 1 commit into
mainfrom
devin/track-61-acp

Conversation

@stpinkie
Copy link
Copy Markdown
Owner

Summary

  • rhizome acp serves the Agent Client Protocol over stdio (Zed/JetBrains drive Rhizome agents): initialize, session/new, streamed session/prompt, cancel — via coder/acp-go-sdk v0.13.5 (≥7d old), all SDK usage confined to pkg/acp.
  • Sessions map to agent:<id>:acp:<sid> explicit keys and run through the normal pipeline via a new AgentLoop.ProcessInbound seam — routing, history, tools, provider fallback preserved.
  • Streaming bridges bus.Streamer (suffix-diff → agent_message_chunk/agent_thought_chunk); tool progress from agent.tool.exec_* events → tool_call/tool_call_update, correlated by new CallID (tc.ID) payload fields.
  • Permission bridge: acp.server.permission_policy = prompt (default)/allow/deny → session/request_permission; *_always cached per session; failures deny closed.
  • stdout protocol hygiene: banner/TZ prints skipped for acp, console logging disabled before config load, RHIZOME_LOG_FILE for diagnostics.
  • --agent <id> pins sessions via a leading dispatch rule.

Binary delta: +593,920 B (+0.57%) windows/amd64 goolm,stdjson — under the 15% gate.

Test plan

  • go test ./pkg/acp — 14 tests (fake runner/conn + real EventBus)
  • go test ./pkg/agent ./pkg/config ./cmd/rhizome ./pkg/modules — green
  • golangci-lint run --build-tags goolm,stdjson ./... — 0 issues
  • Real stdio smoke: initialize → session/new → session/prompt → 3 streamed agent_message_chunk notifications → stopReason: end_turn, clean stdout
  • Zed end-to-end (needs a real model provider — config shape documented in docs/guides/acp.md)

Generated with Devin

@stpinkie
stpinkie changed the base branch from main to devin/track-65-nimbus September 15, 2026 05:11
@stpinkie
stpinkie force-pushed the devin/track-65-nimbus branch from 200b628 to 9cc1d05 Compare September 15, 2026 08:17
Adds an Agent Client Protocol server bridging the Rhizome agent loop to
editor clients (Zed, JetBrains) over stdio JSON-RPC via
github.com/coder/acp-go-sdk v0.13.5 — all SDK usage confined to pkg/acp.

- pkg/acp: Agent impl — initialize (text+image prompt caps), session/new →
  agent:<id>:acp:<sid> explicit session keys, prompt → new
  AgentLoop.ProcessInbound seam on channel "acp" (full InboundMessage:
  media refs + explicit session key), streamed agent_message_chunk /
  agent_thought_chunk via a suffix-diffing bus.Streamer behind an
  in-process StreamDelegate, tool_call/tool_call_update from runtime
  exec events correlated by a new CallID (tc.ID) on the tool payloads.
- Permission bridge: ToolApprover claims channel-acp approvals →
  session/request_permission; *_always cached per session; unreachable
  client/cancel → deny (fails closed). Policy:
  acp.server.permission_policy = prompt|allow|deny.
- rhizome acp [--agent <id>]: dispatch-rule injection pins the agent;
  model streaming force-enabled in-memory; process-local Channels["acp"]
  entry satisfies the channel gate without registering a channel type.
- stdout protocol hygiene: main() skips banner/TZ prints under
  stdioProtocolCommand(); the command disables console logging before
  LoadConfig (diagnostics via RHIZOME_LOG_FILE).
- Binary delta: +593,920 B (+0.57%) windows/amd64.

Verified: pkg/acp unit tests + real stdio smoke (initialize →
session/new → session/prompt → streamed chunks → end_turn) against a
fake SSE OpenAI endpoint.

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@stpinkie
stpinkie changed the base branch from devin/track-65-nimbus to main September 15, 2026 10:03
@stpinkie
stpinkie merged commit d06c025 into main Sep 15, 2026
13 checks passed
@stpinkie
stpinkie deleted the devin/track-61-acp branch September 15, 2026 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0