8000 feat(modules): nimbus-verified-proxy tenant + sha512/nested-archive support (Track 65) by stpinkie · Pull Request #6 · stpinkie/rhizome · GitHub
[go: up one dir, main page]

Skip to content

feat(modules): nimbus-verified-proxy tenant + sha512/nested-archive support (Track 65) - #6

Merged
stpinkie merged 2 commits into
mainfrom
devin/track-65-nimbus
Sep 15, 2026
Merged

stpinkie merged 2 commits into
mainfrom
devin/track-65-nimbus

Conversation

@stpinkie
Copy link
Copy Markdown
Owner

Summary

Track 65 of the v0.10.0 sprint — the first binary module tenant, on top of the Track 60 module system (#5).

  • Catalog entry nimbus-verified-proxy (kind daemon): status-im/nimbus-eth1's verified proxy — a consensus light client serving execution JSON-RPC verified against beacon-chain proofs. Platforms: linux amd64/arm64, windows amd64, macos arm64 (no darwin-amd64 asset exists upstream). Pinned v0.4.1 / ec214533.
  • Field/flag corrections — verified against nimbus_verified_proxy_conf.nim: the draft's --web3-url/--rpc-port guesses were wrong. Real flags: --execution-api-url, --beacon-api-url (a required light-client data provider the draft missed), --trusted-block-root (required, not optional), --network, --listen-url (a full URL, not a port). Both provider URLs are Secret fields — they routinely embed API keys.
  • ReleasePin.SHA512 + Digest(platform) — upstream publishes sha512, not sha256. Explicit per-algo maps; the pinned digest for this release cross-checks against the release notes.
  • InstallSpec.OSAliases — {goos} expansion maps darwin→macos for upstream asset naming.
  • Nested-archive flattening — nimbus ships build/nimbus_verified_proxy[.exe]; extraction now writes the matched binary to the version-dir root where binaryPath looks. .exe resolution on Windows (with bare-name fallback).
  • Health — JSON-RPC eth_chainId POST to {listen_url}.
  • Docs updated (.todo.md, design doc, AGENTS.md) with the verified facts.

Test plan

  • go build + golangci-lint (0 issues) + pkg/modules tests — new: sha512 install/mismatch, nested-archive flatten, OS-alias asset naming, catalog-entry invariants, secret-valued args reach argv
  • Real install on Windows: module install nimbus-verified-proxy downloaded the 23 MB v0.4.1 asset, sha512-verified against the upstream pin, extracted; nimbus_verified_proxy.exe --version runs → v0.4.1-ec214533
  • module status shows unconfigured with correct missing-field list; module validate clean
  • Supervised start/stop with live EL+CL endpoints — deferred to the release gate (Track 66)

Stacked on #5 (Track 60); retargets up the chain as it merges.

Generated with Devin

@stpinkie
stpinkie force-pushed the devin/track-60-modules branch from 96bd969 to 72073be Compare September 15, 2026 07:49
stpinkie and others added 2 commits September 15, 2026 15:49
…upport (Track 65)

First binary tenant: status-im/nimbus-eth1's verified proxy — a consensus
light client serving execution JSON-RPC verified against beacon proofs,
on linux amd64/arm64, windows amd64, macos arm64.

Verified against upstream at impl time (the draft's guesses were wrong):
upstream publishes sha512, not sha256 → ReleasePin gains SHA512 +
Digest(platform); assets label darwin "macos" → InstallSpec.OSAliases;
the binary ships under build/ → extraction flattens it to the version
root; real flags are --execution-api-url/--beacon-api-url/
--trusted-block-root/--network/--listen-url (beacon_api_url was missed
entirely; rpc_port is a full listen URL). Provider URLs are secret fields
since they embed API keys. Smoke: real v0.4.1 install + --version run on
Windows; daemon start needs live EL+CL endpoints (release gate).

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Pre-existing main bugs surfaced by CI on the stacked PRs:

- newCorrelationID derived IDs from time.Now(); on coarse-clock
  Windows runners two adjacent calls returned identical IDs, and the
  agentrpc result cache (keyed by peer+corrID) served request 1's
  response to request 2 — replay rejection and rate limiting were
  silently bypassed. Use crypto-random IDs (shared randomHexToken).
- handleRequestWithCache now only returns a cached response when the
  request nonce matches — same corrID + fresh nonce is a new request,
  not an idempotent retry.
- localCapability invoked manifestSource/manifestSink concurrently
  (announce loop + caps stream handler); serialize the invocation so
  sinks (gateway manifest file writer, test doubles) stay safe.
- swarm Transport.Stop now drains in-flight inbound stream handlers —
  they write audit/run files into the swarm home and raced test
  TempDir cleanup ("directory not empty").
- pkg/modules test golines formatting (modules_test.go:637).

Verified: go test -p 1 -tags goolm,stdjson on mesh/agentrpc/swarm/
modules; CGO_ENABLED=1 go test -race -p 1 on mesh/stream/swarm;
golangci-lint 0 issues.

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@stpinkie
stpinkie force-pushed the devin/track-65-nimbus branch from 200b628 to 9cc1d05 Compare September 15, 2026 08:17
@stpinkie
Copy link
Copy Markdown
Owner Author

Added 9cc1d053 — bundles fixes for pre-existing main bugs this branch's CI run surfaced (not Track-65 regressions):

  • newCorrelationID collision — timestamp-derived IDs collided on coarse Windows clocks; the agentrpc result cache then served request-1's response to request-2, silently bypassing replay rejection and rate limiting (TestMeshReplayedNonceRejected/TestMeshRateLimited flakes). Now crypto-random; cache hits additionally require a nonce match.
  • manifestSink race — localCapability() invoked the sink unsynchronized from the announce loop + caps stream handler (Race Detector failure). Now serialized; also fixes a real concurrent-write hazard on the gateway's manifest files.
  • Swarm TempDir cleanup flake — Transport.Stop now drains in-flight inbound stream handlers that write audit/run files into the swarm home.
  • modules_test.go golines fix (was fixed on track-61, backported here where the lint gate failed).

@stpinkie
stpinkie changed the base branch from devin/track-60-modules to main September 15, 2026 10:03
@stpinkie
stpinkie merged commit f961ce6 into main Sep 15, 2026
37 of 39 checks passed
@stpinkie
stpinkie deleted the devin/track-65-nimbus branch September 15, 2026 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0