-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made the plugin compilation be based on the wrapper functions. #6642
base: main
Are you sure you want to change the base?
Conversation
34a6fda
to
c0e38c8
Compare
c0e38c8
to
5ecd1e1
Compare
5ecd1e1
to
8878fa6
Compare
ebd2759
to
4d219df
Compare
commit-id:4213f446
8878fa6
to
08c3011
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @orizi)
crates/cairo-lang-runnable/src/compile.rs
line 79 at r1 (raw file):
/// Returns the path to the function that the runnable is wrapping. /// /// If the runnable is not wrapping a function, returns the full path of the runnable.
It is possible only if writing a runnable manually, right?
Code quote:
/// If the runnable is not wrapping a function, returns the full path of the runnable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware)
crates/cairo-lang-runnable/src/compile.rs
line 79 at r1 (raw file):
Previously, gilbens-starkware (Gil Ben-Shachar) wrote…
It is possible only if writing a runnable manually, right?
yes.
Stack:
runnable_raw
attribute. #6648