New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix hyperparameter validations of dr-variants #77

Merged

usaito merged 1 commit into st-tech:master from fullflu:allow-integer-hyperparams

Mar 7, 2021

Contributor

fullflu commented

•

Overview

We cannot set integers to the hyperparameters of Switch-DR and DRos #74

Change points

fix hyperparameter validations in estimators.py
- allow interger
- reject np.nan
add several tests to check the validations


          fix hyperparameter validations of dr-variants

2e1cd0b

Contributor

usaito commented

@fullflu Thanks! LGTM!

usaito merged commit d4c2502 into st-tech:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet