add check-scalar #122
Merged
add check-scalar #122
+573
−550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usaito
reviewed
Sep 5, 2021
obp/policy/logistic.py
Outdated
| f"lambda_ should be a positive float, but {self.lambda_} is given" | ||
| ) | ||
| check_scalar(self.lambda_, "lambda_", float) | ||
| if self.alpha_ <= 0.0: |
There was a problem hiding this comment.
I will add several tests about those arguments...!
obp/policy/linear.py
Outdated
| ) | ||
| check_array(array=context, name="context", expected_dim=2) | ||
| if context.shape[0] != 1: | ||
| raise ValueError("Expected `context.shape[1] == 1`, but found it False") |
There was a problem hiding this comment.
"Expected context.shape[0] == 1, but found it False" ?
obp/policy/linear.py
Outdated
| ) | ||
| check_array(array=context, name="context", expected_dim=2) | ||
| if context.shape[0] != 1: | ||
| raise ValueError("Expected `context.shape[1] == 1`, but found it False") |
There was a problem hiding this comment.
"Expected context.shape[0] == 1, but found it False" ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
check_scalarfunction to validate scalar (int or float) variablesskearn.utils.check_scalarChange point
Remark
a >= 0easily by thecheck_scalarfunction, the condition ofa > 0cannot be checked easily by the function. Thus, we manually check the condition.