Address comments from PR #403 Improve pool navigation/browsing #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zurubooru into update/Ruin0x11/improve-pools
…ast-created secondary ordering
|
My fork includes a bunch of styling fixes for pool thumbnails, a bugfix for pool navigation, and a performance optimization for nearby posts serialization. |
|
Oh, nice! @po5 does that render the changes in this branch redundant? I can close this PR if that's the case, no need to pollute an already dense PR list. |
|
I haven't submitted my pool-related changes yet so feel free to cherry pick. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes the commits introduced in PR #403, which appears to be abandoned by the contributor, and applies the suggestions in that PR and updates the code to fix merge conflicts and broken tests that occurred as a result of master branch diverging from the PR.
It includes the original changes from that PR. In addition, I re-arranged the Dockerfile for server to make caching a little easier (mostly, doing package installs prior to any COPYs to stop 0.5GB images from being generated on every code change), and to add a default BUILDPLATFORM build arg so that it does not need to be explicitly passed via buildargs. Those additions can be pulled out and discussed separately (or wholesale rejected) but I figured I'd keep them in this PR and see if they would be helpful to others.
In addition, this includes the following changes, copied verbatim from PR #403:
Related to #380.
Implements
sort:poolfor post searches, which will sort the results by the order defined by thepool:named token in the same search query.Modifies the previous/next post order for the post view if a
pool:named token is in the current query.Adds a grid-based view for the pools list page, showing up to the first three posts in each pool.
Implements pool navigators. They allow navigating to the first/last/next/previous post in each pool the post belongs to. The current pool active in the search query will get bolded/placed at the top.
