Respect EXIF orientation #614
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exiftool presents similar data to ffprobe, so it may be used as a replacement. notably, this change will give us access to the "Orientation" tag, which ffprobe does not provide. [server] install exiftool on the docker image [server] replace Image._reload_info's implementation with a call to exiftool [server] remove unused Image.frames property; replace with Image.duration
This change resolves https://github.com/rr-/szurubooru/issues/470 As well as correcting a related issue with thumbnail rotation. Based on the EXIF Orientation data, we correctly size the scaled image in the post view, and rotate the image before creating its thumbnail.
PIL provides built-in support for transposing images based on EXIF Orientation. This change adds that call.
Raise an exception when exiftool provides a Warning or Error, which usually indicates a corrupted file. This exception is handled by the allow_broken_uploads setting.
The test creates a new post, containing a known image which has been rotated 90 degrees. It then checks: - the size of the canvas - the size of the thumbnail - if the image is searchable using non-exif data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR checks EXIF orientation. Addresses #470.
Method
Calls to ffprobe are replaced with exiftool (supported file formats: https://exiftool.org/TagNames/)
exiftool is capable of getting the metadata we want for static images and video, and gives us access to an image's Orientation.
Alternative
This branch is heavily inspired by skybldev's work here: https://github.com/rr-/szurubooru/pull/499.
Differences:
Limitations
This PR is still missing unit tests for EXIF images.[added in 4ad9000]