8000 refactor(rome_js_analyze): improve `useEnumInitializers` by Conaclos · Pull Request #4733 · rome/tools · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Aug 31, 2023. It is now read-only.

refactor(rome_js_analyze): improve useEnumInitializers - #4733

Merged
Conaclos merged 1 commit into
rome:mainfrom
Conaclos:use_enum_initializers_improvements
Jul 30, 2023
Merged

refactor(rome_js_analyze): improve useEnumInitializers#4733
Conaclos merged 1 commit into
rome:mainfrom
Conaclos:use_enum_initializers_improvements

Conversation

@Conaclos
@Conaclos Conaclos commented Jul 28, 2023
Copy link
Copy Markdown
Contributor

Summary

The rule now reports all uninitialized members of an enum in a single diagnostic.
This reduces the noise produced by the rule.
This also simplifies the implementation of the quick-fix.

Moreover, ambient enum declarations are now ignored.
This avoids reporting ambient enum declarations in TypeScript declaration files.

declare enum Weather {
  Rainy,
  Sunny,
}

Test Plan

New tests included.

@netlify
netlify Bot commented Jul 28, 2023 •
edited
Loading
Copy link
Copy Markdown

✅ Deploy Preview for docs-rometools canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 8209818
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/64c638d5401b020008f2146e

@github-actions github-actions Bot added A-Website Area: website and documentation A-Linter Area: linter L-JavaScript Langauge: JavaScript labels Jul 28, 2023
@Conaclos
Conaclos requested a review from ematipico July 28, 2023 13:10
ematipico
ematipico approved these changes Jul 30, 2023
View reviewed changes
Comment thread CHANGELOG.md Resolved
@Conaclos
Conaclos merged commit 675b8ed into rome:main Jul 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@ematipico ematipico ematipico approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Linter Area: linter A-Website Area: website and documentation L-JavaScript Langauge: JavaScript

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Conaclos @ematipico
0