This repository was archived by the owner on Aug 31, 2023. It is now read-only.
Repository navigation
feat(rome_js_analyze): add options to noRestrictedGlobals - #4723
Merged
Merged
Conversation
✅ Deploy Preview for docs-rometools canceled.
|
ematipico
force-pushed
the
feat/restricted-globals
branch
2 times, most recently
from
July 23, 2023 16:46
605b66a to
ed7ffe9
Compare
Parser conformance results on ubuntu-latestjs/262
jsx/babel
symbols/microsoft
ts/babel
ts/microsoft
|
ematipico
force-pushed
the
feat/restricted-globals
branch
from
July 23, 2023 16:52
ed7ffe9 to
f4f195e
Compare
ematipico
force-pushed
the
feat/restricted-globals
branch
from
July 23, 2023 17:40
f4f195e to
6c8aa48
Compare
ematipico
force-pushed
the
feat/restricted-globals
branch
from
July 23, 2023 17:40
6c8aa48 to
d9f2e37
Compare
Contributor
|
@ematipico Got it, thanks for the heads-up! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #4628
@arendjr Fixed a problem in the document with the rule you recently implemented in this PR. When documenting INVALID cases, the snippet must raise one single diagnostic; otherwise, the documentation generated isn't correct. (I wonder why the script doesn't panic anymore, it used to).
Test Plan
Added a new test case